Settings search - Don't send error telemetry with no details

src/vs/platform/request/electron-browser/requestService.ts

@@ -51,7 +51,7 @@ export const xhrRequest: IRequestFunction = (options: IRequestOptions): TPromise
 		setRequestHeaders(xhr, options);
 
 		xhr.responseType = 'arraybuffer';
-		xhr.onerror = e => reject(new Error('XHR failed: ' + xhr.statusText));
+		xhr.onerror = e => reject(new Error(xhr.statusText && ('XHR failed: ' + xhr.statusText)));
 		xhr.onload = (e) => {
 			resolve({
 				res: {

src/vs/workbench/parts/preferences/browser/preferencesEditor.ts

@@ -518,8 +518,12 @@ class PreferencesRenderersController extends Disposable {
 								"message": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
 							}
 						*/
-						const message = getErrorMessage(err);
-						this.telemetryService.publicLog('defaultSettings.searchError', { message });
+						const message = getErrorMessage(err).trim();
+						if (message) {
+							// Empty message = any generic network error
+							this.telemetryService.publicLog('defaultSettings.searchError', { message });
+						}
+
 						return null;
 					}
 				})