Strict init and mark events readonly

#78168

src/vs/platform/windows/common/windows.ts

@@ -96,12 +96,12 @@ export interface IWindowsService {
 
 	_serviceBrand: any;
 
-	onWindowOpen: Event<number>;
-	onWindowFocus: Event<number>;
-	onWindowBlur: Event<number>;
-	onWindowMaximize: Event<number>;
-	onWindowUnmaximize: Event<number>;
-	onRecentlyOpenedChange: Event<void>;
+	readonly onWindowOpen: Event<number>;
+	readonly onWindowFocus: Event<number>;
+	readonly onWindowBlur: Event<number>;
+	readonly onWindowMaximize: Event<number>;
+	readonly onWindowUnmaximize: Event<number>;
+	readonly onRecentlyOpenedChange: Event<void>;
 
 	// Dialogs
 	pickFileFolderAndOpen(options: INativeOpenDialogOptions): Promise<void>;

src/vs/platform/windows/common/windowsIpc.ts

@@ -12,14 +12,14 @@ import { IRecent, isRecentFile, isRecentFolder } from 'vs/platform/history/commo
 
 export class WindowsChannel implements IServerChannel {
 
-	private onWindowOpen: Event<number>;
-	private onWindowFocus: Event<number>;
-	private onWindowBlur: Event<number>;
-	private onWindowMaximize: Event<number>;
-	private onWindowUnmaximize: Event<number>;
-	private onRecentlyOpenedChange: Event<void>;
+	private readonly onWindowOpen: Event<number>;
+	private readonly onWindowFocus: Event<number>;
+	private readonly onWindowBlur: Event<number>;
+	private readonly onWindowMaximize: Event<number>;
+	private readonly onWindowUnmaximize: Event<number>;
+	private readonly onRecentlyOpenedChange: Event<void>;
 
-	constructor(private service: IWindowsService) {
+	constructor(private readonly service: IWindowsService) {
 		this.onWindowOpen = Event.buffer(service.onWindowOpen, true);
 		this.onWindowFocus = Event.buffer(service.onWindowFocus, true);
 		this.onWindowBlur = Event.buffer(service.onWindowBlur, true);
@@ -120,4 +120,4 @@ export class WindowsChannel implements IServerChannel {
 
 		throw new Error(`Call not found: ${command}`);
 	}
-}
\ No newline at end of file
+}

src/vs/workbench/test/workbenchTestServices.ts

@@ -1340,12 +1340,12 @@ export class TestWindowsService implements IWindowsService {
 
 	public windowCount = 1;
 
-	onWindowOpen: Event<number>;
-	onWindowFocus: Event<number>;
-	onWindowBlur: Event<number>;
-	onWindowMaximize: Event<number>;
-	onWindowUnmaximize: Event<number>;
-	onRecentlyOpenedChange: Event<void>;
+	readonly onWindowOpen: Event<number> = Event.None;
+	readonly onWindowFocus: Event<number> = Event.None;
+	readonly onWindowBlur: Event<number> = Event.None;
+	readonly onWindowMaximize: Event<number> = Event.None;
+	readonly onWindowUnmaximize: Event<number> = Event.None;
+	readonly onRecentlyOpenedChange: Event<void> = Event.None;
 
 	isFocused(_windowId: number): Promise<boolean> {
 		return Promise.resolve(false);