Unregister comment controller when it is disposed

src/vs/workbench/api/electron-browser/mainThreadComments.ts

@@ -451,6 +451,13 @@ export class MainThreadComments extends Disposable implements MainThreadComments
 		this._commentService.setWorkspaceComments(String(handle), []);
 	}
 
+	$unregisterCommentController(handle: number): void {
+		const providerId = this._handlers.get(handle);
+		this._commentService.unregisterCommentController(providerId);
+		this._handlers.delete(handle);
+		this._commentControllers.delete(handle);
+	}
+
 	$updateCommentControllerFeatures(handle: number, features: CommentProviderFeatures): void {
 		let provider = this._commentControllers.get(handle);
 

src/vs/workbench/api/node/extHost.protocol.ts

@@ -121,6 +121,7 @@ export interface CommentProviderFeatures {
 
 export interface MainThreadCommentsShape extends IDisposable {
 	$registerCommentController(handle: number, id: string, label: string): void;
+	$unregisterCommentController(handle: number): void;
 	$updateCommentControllerFeatures(handle: number, features: CommentProviderFeatures): void;
 	$createCommentThread(handle: number, commentThreadHandle: number, threadId: string, resource: UriComponents, range: IRange, comments: modes.Comment[], acceptInputCommand: modes.Command | undefined, additionalCommands: modes.Command[], collapseState: modes.CommentThreadCollapsibleState): modes.CommentThread2 | undefined;
 	$deleteCommentThread(handle: number, commentThreadHandle: number): void;

src/vs/workbench/api/node/extHostComments.ts

@@ -564,6 +564,8 @@ class ExtHostCommentController implements vscode.CommentController {
 		this._threads.forEach(value => {
 			value.dispose();
 		});
+
+		this._proxy.$unregisterCommentController(this.handle);
 	}
 }
 

src/vs/workbench/contrib/comments/electron-browser/commentService.ts

@@ -45,6 +45,7 @@ export interface ICommentService {
 	setWorkspaceComments(owner: string, commentsByResource: CommentThread[]): void;
 	removeWorkspaceComments(owner: string): void;
 	registerCommentController(owner: string, commentControl: MainThreadCommentController): void;
+	unregisterCommentController(owner: string): void;
 	registerDataProvider(owner: string, commentProvider: DocumentCommentProvider): void;
 	unregisterDataProvider(owner: string): void;
 	updateComments(ownerId: string, event: CommentThreadChangedEvent): void;
@@ -133,6 +134,11 @@ export class CommentService extends Disposable implements ICommentService {
 		this._onDidSetDataProvider.fire();
 	}
 
+	unregisterCommentController(owner: string): void {
+		this._commentControls.delete(owner);
+		this._onDidDeleteDataProvider.fire(owner);
+	}
+
 	registerDataProvider(owner: string, commentProvider: DocumentCommentProvider): void {
 		this._commentProviders.set(owner, commentProvider);
 		this._onDidSetDataProvider.fire();