提交 33371a88 编写于 作者: C Christof Marti

'Type to narrow down results' only for QuickPick (fixes #58105)

上级 e90887a7
...@@ -302,6 +302,8 @@ class QuickInput implements IQuickInput { ...@@ -302,6 +302,8 @@ class QuickInput implements IQuickInput {
class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPick<T> { class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPick<T> {
private static INPUT_BOX_ARIA_LABEL = localize('quickInputBox.ariaLabel', "Type to narrow down results.");
private _value = ''; private _value = '';
private _placeholder; private _placeholder;
private onDidChangeValueEmitter = new Emitter<string>(); private onDidChangeValueEmitter = new Emitter<string>();
...@@ -622,6 +624,7 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi ...@@ -622,6 +624,7 @@ class QuickPick<T extends IQuickPickItem> extends QuickInput implements IQuickPi
this.ui.list.matchOnDescription = this.matchOnDescription; this.ui.list.matchOnDescription = this.matchOnDescription;
this.ui.list.matchOnDetail = this.matchOnDetail; this.ui.list.matchOnDetail = this.matchOnDetail;
this.ui.setComboboxAccessibility(true); this.ui.setComboboxAccessibility(true);
this.ui.inputBox.setAttribute('aria-label', QuickPick.INPUT_BOX_ARIA_LABEL);
this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true }); this.ui.setVisibilities(this.canSelectMany ? { title: !!this.title || !!this.step, checkAll: true, inputBox: true, visibleCount: true, count: true, ok: true, list: true } : { title: !!this.title || !!this.step, inputBox: true, visibleCount: true, list: true });
} }
} }
...@@ -1225,6 +1228,7 @@ export class QuickInputService extends Component implements IQuickInputService { ...@@ -1225,6 +1228,7 @@ export class QuickInputService extends Component implements IQuickInputService {
this.ui.list.matchOnDetail = false; this.ui.list.matchOnDetail = false;
this.ui.ignoreFocusOut = false; this.ui.ignoreFocusOut = false;
this.setComboboxAccessibility(false); this.setComboboxAccessibility(false);
this.ui.inputBox.removeAttribute('aria-label');
const keybinding = this.keybindingService.lookupKeybinding(BackAction.ID); const keybinding = this.keybindingService.lookupKeybinding(BackAction.ID);
backButton.tooltip = keybinding ? localize('quickInput.backWithKeybinding', "Back ({0})", keybinding.getLabel()) : localize('quickInput.back', "Back"); backButton.tooltip = keybinding ? localize('quickInput.backWithKeybinding', "Back ({0})", keybinding.getLabel()) : localize('quickInput.back', "Back");
......
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
import 'vs/css!./quickInput'; import 'vs/css!./quickInput';
import * as dom from 'vs/base/browser/dom'; import * as dom from 'vs/base/browser/dom';
import { InputBox, IRange, MessageType } from 'vs/base/browser/ui/inputbox/inputBox'; import { InputBox, IRange, MessageType } from 'vs/base/browser/ui/inputbox/inputBox';
import { localize } from 'vs/nls';
import { inputBackground, inputForeground, inputBorder, inputValidationInfoBackground, inputValidationInfoForeground, inputValidationInfoBorder, inputValidationWarningBackground, inputValidationWarningForeground, inputValidationWarningBorder, inputValidationErrorBackground, inputValidationErrorForeground, inputValidationErrorBorder } from 'vs/platform/theme/common/colorRegistry'; import { inputBackground, inputForeground, inputBorder, inputValidationInfoBackground, inputValidationInfoForeground, inputValidationInfoBorder, inputValidationWarningBackground, inputValidationWarningForeground, inputValidationWarningBorder, inputValidationErrorBackground, inputValidationErrorForeground, inputValidationErrorBorder } from 'vs/platform/theme/common/colorRegistry';
import { ITheme } from 'vs/platform/theme/common/themeService'; import { ITheme } from 'vs/platform/theme/common/themeService';
import { dispose, IDisposable } from 'vs/base/common/lifecycle'; import { dispose, IDisposable } from 'vs/base/common/lifecycle';
...@@ -17,8 +16,6 @@ import Severity from 'vs/base/common/severity'; ...@@ -17,8 +16,6 @@ import Severity from 'vs/base/common/severity';
const $ = dom.$; const $ = dom.$;
const DEFAULT_INPUT_ARIA_LABEL = localize('quickInputBox.ariaLabel', "Type to narrow down results.");
export class QuickInputBox { export class QuickInputBox {
private container: HTMLElement; private container: HTMLElement;
...@@ -29,9 +26,7 @@ export class QuickInputBox { ...@@ -29,9 +26,7 @@ export class QuickInputBox {
private parent: HTMLElement private parent: HTMLElement
) { ) {
this.container = dom.append(this.parent, $('.quick-input-box')); this.container = dom.append(this.parent, $('.quick-input-box'));
this.inputBox = new InputBox(this.container, null, { this.inputBox = new InputBox(this.container, null);
ariaLabel: DEFAULT_INPUT_ARIA_LABEL
});
this.disposables.push(this.inputBox); this.disposables.push(this.inputBox);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册