add Codicon.dropDownButton

src/vs/base/browser/ui/button/button.ts

@@ -15,8 +15,7 @@ import { renderCodicons } from 'vs/base/browser/codicons';
 import { addDisposableListener, IFocusTracker, EventType, EventHelper, trackFocus, reset, removeTabIndexAndUpdateFocus } from 'vs/base/browser/dom';
 import { IContextMenuProvider } from 'vs/base/browser/contextmenu';
 import { IAction, IActionRunner } from 'vs/base/common/actions';
-import { Codicon, CSSIcon, registerIcon } from 'vs/base/common/codicons';
-import { localize } from 'vs/nls';
+import { CSSIcon, Codicon } from 'vs/base/common/codicons';
 
 export interface IButtonOptions extends IButtonStyles {
 	readonly title?: boolean | string;
@@ -238,8 +237,6 @@ export interface IButtonWithDropdownOptions extends IButtonOptions {
 	readonly actionRunner?: IActionRunner;
 }
 
-const dropdownIcon = registerIcon('button-drow-down', Codicon.chevronDown, localize('dropdownIcon', 'Icon for button with dropdowns'));
-
 export class ButtonWithDropdown extends Disposable implements IButton {
 
 	private readonly button: Button;
@@ -260,7 +257,7 @@ export class ButtonWithDropdown extends Disposable implements IButton {
 
 		this.dropdownButton = this._register(new Button(this.element, { ...options, title: false, supportCodicons: true }));
 		this.dropdownButton.element.classList.add('monaco-dropdown-button');
-		this.dropdownButton.icon = dropdownIcon;
+		this.dropdownButton.icon = Codicon.dropDownButton;
 		this._register(this.dropdownButton.onDidClick(() => {
 			options.contextMenuProvider.showContextMenu({
 				getAnchor: () => this.dropdownButton.element,

src/vs/base/browser/ui/dropdown/dropdownActionViewItem.ts

@@ -13,6 +13,7 @@ import { Emitter } from 'vs/base/common/event';
 import { ActionViewItem, BaseActionViewItem, IActionViewItemOptions, IBaseActionViewItemOptions } from 'vs/base/browser/ui/actionbar/actionViewItems';
 import { IActionProvider, DropdownMenu, IDropdownMenuOptions, ILabelRenderer } from 'vs/base/browser/ui/dropdown/dropdown';
 import { IContextMenuProvider } from 'vs/base/browser/contextmenu';
+import { Codicon } from 'vs/base/common/codicons';
 
 export interface IKeybindingProvider {
 	(action: IAction): ResolvedKeybinding | undefined;
@@ -169,7 +170,7 @@ export class ActionWithDropdownActionViewItem extends ActionViewItem {
 		super.render(container);
 		if (this.element) {
 			this.element.classList.add('action-dropdown-item');
-			this.dropdownMenuActionViewItem = new DropdownMenuActionViewItem(new Action('dropdownAction', undefined), (<IActionWithDropdownActionViewItemOptions>this.options).menuActionsOrProvider, this.contextMenuProvider, { classNames: ['dropdown', 'codicon-chevron-down', ...(<IActionWithDropdownActionViewItemOptions>this.options).menuActionClassNames || []] });
+			this.dropdownMenuActionViewItem = new DropdownMenuActionViewItem(new Action('dropdownAction', undefined), (<IActionWithDropdownActionViewItemOptions>this.options).menuActionsOrProvider, this.contextMenuProvider, { classNames: ['dropdown', ...Codicon.dropDownButton.classNamesArray, ...(<IActionWithDropdownActionViewItemOptions>this.options).menuActionClassNames || []] });
 			this.dropdownMenuActionViewItem.render(this.element);
 		}
 	}

src/vs/base/common/codicons.ts

@@ -5,6 +5,7 @@
 
 import { codiconStartMarker } from 'vs/base/common/codicon';
 import { Emitter, Event } from 'vs/base/common/event';
+import { localize } from 'vs/nls';
 
 export interface IIconRegistry {
 	readonly all: IterableIterator<Codicon>;
@@ -496,8 +497,12 @@ export namespace Codicon {
 	export const passFilled = new Codicon('pass-filled', { character: '\\ebb3' });
 	export const circleLargeFilled = new Codicon('circle-large-filled', { character: '\\ebb4' });
 	export const circleLargeOutline = new Codicon('circle-large-outline', { character: '\\ebb5' });
+
+	export const dropDownButton = new Codicon('drop-down-button', Codicon.chevronDown.definition);
 }
 
+// common icons
+