theming 💄

src/vs/base/browser/ui/findinput/findInput.css

@@ -28,28 +28,6 @@
 	right: 2px;
 }
 
-.monaco-findInput > .controls > .matchCount {
-	margin-left: 2px;
-	float: left;
-	overflow: hidden;
-	max-width: 30px;
-	min-width: 20px;
-	text-align: center;
-
-	border-radius: 5px;
-	padding: 0 4px;
-
-	-webkit-box-sizing:	border-box;
-	-o-box-sizing:		border-box;
-	-moz-box-sizing:	border-box;
-	-ms-box-sizing:		border-box;
-	box-sizing:			border-box;
-}
-
-.vs .monaco-findInput > .controls > .matchCount {
-	background: #ddd;
-}
-
 .vs .monaco-findInput.disabled {
 	background-color: #E1E1E1;
 }
@@ -59,10 +37,6 @@
 	background-color: #333;
 }
 
-.vs-dark .monaco-findInput > .controls > .matchCount {
-	background: #555;
-}
-
 /* Highlighting */
 .monaco-findInput.highlight-0 .controls {
 	animation: monaco-findInput-highlight-0 100ms linear 0s;

src/vs/workbench/parts/debug/browser/debugActionItems.ts

@@ -117,8 +117,8 @@ export class StartDebugActionItem extends EventEmitter implements IActionItem {
 			}
 		}));
 		this.toDispose.push(attachStylerCallback(this.themeService, { selectBorder }, colors => {
-			this.container.style.borderColor = colors.selectBorder;
-			selectBoxContainer.style.borderLeftColor = colors.selectBorder;
+			this.container.style.border = colors.selectBorder ? `1px solid ${colors.selectBorder}` : null;
+			selectBoxContainer.style.borderLeft = colors.selectBorder ? `1px solid ${colors.selectBorder}` : null;
 		}));
 
 		this.updateOptions();

src/vs/workbench/parts/debug/browser/media/breakpointWidget.css

@@ -16,10 +16,6 @@
 	padding: 0 10px;
 }
 
-.monaco-editor .zone-widget .zone-widget-container.breakpoint-widget .breakpoint-select-container .select-box {
-	border-color: rgba(128, 128, 128, 0.35);
-}
-
 .monaco-editor .zone-widget .zone-widget-container.breakpoint-widget .inputBoxContainer {
 	flex: 1;
 }

src/vs/workbench/parts/debug/browser/media/debugViewlet.css

@@ -57,7 +57,6 @@
 	margin-right: 0.3em;
 	height: 20px;
 	flex-shrink: 1;
-	border: 1px solid #dddddd;
 	margin-top: 7px;
 }
 
@@ -65,11 +64,6 @@
 	border-radius: 4px;
 }
 
-.vs-dark .monaco-workbench > .part > .title > .title-actions .start-debug-action-item,
-.hc-black .monaco-workbench > .part > .title > .title-actions .start-debug-action-item {
-	border-color: #3c3c3c;
-}
-
 .monaco-workbench > .part > .title > .title-actions .start-debug-action-item .icon {
 	height: 20px;
 	width: 20px;
@@ -84,15 +78,6 @@
 	background: url('continue-inverse.svg') center center no-repeat;
 }
 
-.monaco-workbench > .part > .title > .title-actions .start-debug-action-item .configuration {
-	border-left: 1px solid #dddddd;
-}
-
-.vs-dark .monaco-workbench > .part > .title > .title-actions .start-debug-action-item .configuration,
-.hc-black .monaco-workbench > .part > .title > .title-actions .start-debug-action-item .configuration {
-	border-color: #3c3c3c;
-}
-
 .monaco-workbench .monaco-action-bar .start-debug-action-item .configuration .select-box {
 	border: none;
 	margin-top: 0px;

src/vs/workbench/parts/extensions/browser/extensionsActions.ts

@@ -33,7 +33,7 @@ import URI from 'vs/base/common/uri';
 import { CommandsRegistry } from 'vs/platform/commands/common/commands';
 import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
 import { registerThemingParticipant, ITheme, ICssStyleCollector } from "vs/platform/theme/common/themeService";
-import { buttonBackground, buttonForeground, buttonHoverBackground, contrastBorder, registerColor } from "vs/platform/theme/common/colorRegistry";
+import { buttonBackground, buttonForeground, buttonHoverBackground, contrastBorder, registerColor, foreground } from "vs/platform/theme/common/colorRegistry";
 import { Color } from "vs/base/common/color";
 
 export class InstallAction extends Action {
@@ -1408,6 +1408,11 @@ export const extensionButtonProminentHoverBackground = registerColor('extensionB
 }, localize('extensionButtonProminentHoverBackground', "Button background hover color for actions extension that stand out (e.g. install button)."));
 
 registerThemingParticipant((theme: ITheme, collector: ICssStyleCollector) => {
+	const foregroundColor = theme.getColor(foreground);
+	if (foregroundColor) {
+		collector.addRule(`.monaco-action-bar .action-item .action-label.extension-action.built-in-status { border-color: ${foregroundColor}; }`);
+	}
+
 	const buttonBackgroundColor = theme.getColor(buttonBackground);
 	if (buttonBackgroundColor) {
 		collector.addRule(`.monaco-action-bar .action-item .action-label.extension-action { background-color: ${buttonBackgroundColor}; }`);

src/vs/workbench/parts/extensions/browser/media/extensionActions.css

@@ -36,7 +36,6 @@
 
 .monaco-action-bar .action-item .action-label.extension-action.built-in-status {
 	border-radius: 4px;
-	border-color: #c1c1c1;
 	color: inherit;
 	background-color: transparent;
 	opacity: 0.9;

src/vs/workbench/parts/preferences/browser/keybindingsEditor.ts

@@ -33,12 +33,13 @@ import { IKeybindingEditingService } from 'vs/workbench/services/keybinding/comm
 import { IListService } from 'vs/platform/list/browser/listService';
 import { List } from 'vs/base/browser/ui/list/listWidget';
 import { IDelegate, IRenderer, IListContextMenuEvent, IListEvent } from 'vs/base/browser/ui/list/list';
-import { IThemeService } from 'vs/platform/theme/common/themeService';
+import { IThemeService, registerThemingParticipant, ITheme, ICssStyleCollector } from 'vs/platform/theme/common/themeService';
 import { IContextKeyService, IContextKey } from 'vs/platform/contextkey/common/contextkey';
 import { IChoiceService, IMessageService, Severity } from 'vs/platform/message/common/message';
 import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
 import { KeyCode, ResolvedKeybinding } from 'vs/base/common/keyCodes';
 import { attachListStyler } from 'vs/platform/theme/common/styler';
+import { listHighlightForeground } from "vs/platform/theme/common/colorRegistry";
 
 let $ = DOM.$;
 
@@ -797,4 +798,11 @@ class WhenColumn extends Column {
 	private getAriaLabel(keybindingItemEntry: IKeybindingItemEntry): string {
 		return keybindingItemEntry.keybindingItem.when ? localize('whenAriaLabel', "When is {0}.", keybindingItemEntry.keybindingItem.when) : localize('noWhen', "No when context.");
 	}
-}
\ No newline at end of file
+}
+
+registerThemingParticipant((theme: ITheme, collector: ICssStyleCollector) => {
+	const listHighlightForegroundColor = theme.getColor(listHighlightForeground);
+	if (listHighlightForegroundColor) {
+		collector.addRule(`.keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list-row > .column .highlight { color: ${listHighlightForegroundColor}; }`);
+	}
+});
\ No newline at end of file

src/vs/workbench/parts/preferences/browser/media/keybindingsEditor.css

@@ -148,19 +148,9 @@
 }
 
 .keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list-row > .column .highlight {
-	color: #007ACC;
 	font-weight: bold;
 }
 
-.keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list:focus .monaco-list-row.selected > .column .highlight {
-	color: #1b3c53;
-}
-
-.vs-dark .keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list:focus .monaco-list-row.selected > .column .highlight,
-.hc-black .keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list:focus .monaco-list-row.selected > .column .highlight {
-	color: #049aff;
-}
-
 .keybindings-editor > .keybindings-body > .keybindings-list-container .monaco-list-row > .column .monaco-action-bar {
 	display: none;
 	flex: 1;