output: OutputPanel override getId() instead of messing with StringEditor...

output: OutputPanel override getId() instead of messing with StringEditor (causes api tests to fail)

src/vs/workbench/browser/parts/editor/stringEditor.ts

@@ -39,7 +39,6 @@ export class StringEditor extends BaseTextEditor {
 	private mapResourceToEditorViewState: { [resource: string]: IEditorViewState; };
 
 	constructor(
-		id: string,
 		@ITelemetryService telemetryService: ITelemetryService,
 		@IInstantiationService instantiationService: IInstantiationService,
 		@IWorkspaceContextService contextService: IWorkspaceContextService,
@@ -50,8 +49,7 @@ export class StringEditor extends BaseTextEditor {
 		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
 		@IModeService modeService: IModeService
 	) {
-
-		super(id, telemetryService, instantiationService, contextService, storageService, messageService, configurationService, eventService, editorService, modeService);
+		super(StringEditor.ID, telemetryService, instantiationService, contextService, storageService, messageService, configurationService, eventService, editorService, modeService);
 
 		this.defaultWrappingColumn = DefaultConfig.editor.wrappingColumn;
 		this.defaultLineNumbers = DefaultConfig.editor.lineNumbers;

src/vs/workbench/parts/output/browser/outputPanel.ts

@@ -40,11 +40,15 @@ export class OutputPanel extends StringEditor {
 		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
 		@IModeService modeService: IModeService
 	) {
-		super(OUTPUT_PANEL_ID, telemetryService, instantiationService, contextService, storageService,
+		super(telemetryService, instantiationService, contextService, storageService,
 			messageService, configurationService, eventService, editorService, modeService);
 		this.toDispose = [];
 	}
 
+	public getId(): string {
+		return OUTPUT_PANEL_ID;
+	}
+
 	public getActions(): IAction[] {
 		if (!this.actions) {
 			this.actions = [