check commit

src/vs/platform/configuration/test/common/testConfigurationService.ts

@@ -6,11 +6,13 @@
 import { TernarySearchTree } from 'vs/base/common/map';
 import { URI } from 'vs/base/common/uri';
 import { getConfigurationKeys, IConfigurationOverrides, IConfigurationService, getConfigurationValue, isConfigurationOverrides, IConfigurationValue } from 'vs/platform/configuration/common/configuration';
+import { Emitter } from 'vs/base/common/event';
 
 export class TestConfigurationService implements IConfigurationService {
 	public _serviceBrand: undefined;
 
 	private configuration: any;
+	readonly onDidChangeConfiguration = new Emitter<any>().event;
 
 	constructor(configuration?: any) {
 		this.configuration = configuration || Object.create(null);
@@ -53,10 +55,6 @@ export class TestConfigurationService implements IConfigurationService {
 		return Promise.resolve(undefined);
 	}
 
-	public onDidChangeConfiguration() {
-		return { dispose() { } };
-	}
-
 	public inspectValue<T>(key: string): IConfigurationValue<T> {
 		const inspect = this.inspect<T>(key);
 		return {

src/vs/platform/telemetry/test/electron-browser/telemetryService.test.ts

@@ -768,6 +768,7 @@ suite('TelemetryService', () => {
 		let service = new TelemetryService({
 			appender: testAppender
 		}, new class extends TestConfigurationService {
+			onDidChangeConfiguration = emitter.event;
 			getValue() {
 				return {
 					enableTelemetry: enableTelemetry