Fix #37395 - ignore git output. Also only compute when needed

build/gulpfile.vscode.js

@@ -210,7 +210,6 @@ function computeChecksum(filename) {
 	return hash;
 }
 
-const settingsSearchBuildId = getBuildNumber();
 function packageTask(platform, arch, opts) {
 	opts = opts || {};
 
@@ -275,6 +274,7 @@ function packageTask(platform, arch, opts) {
 		const packageJsonStream = gulp.src(['package.json'], { base: '.' })
 			.pipe(json({ name, version }));
 
+		const settingsSearchBuildId = getBuildNumber();
 		const date = new Date().toISOString();
 		const productJsonStream = gulp.src(['product.json'], { base: '.' })
 			.pipe(json({ commit, date, checksums, settingsSearchBuildId }));
@@ -462,6 +462,7 @@ gulp.task('upload-vscode-configuration', ['generate-vscode-configuration'], () =
 		return;
 	}
 
+	const settingsSearchBuildId = getBuildNumber();
 	if (!settingsSearchBuildId) {
 		console.error('Failed to compute build number');
 		return;
@@ -500,7 +501,7 @@ function getBuildNumber() {
 function getPreviousVersion(versionStr) {
 	function tagExists(tagName) {
 		try {
-			cp.execSync(`git rev-parse ${tagName}`);
+			cp.execSync(`git rev-parse ${tagName}`, { stdio: 'ignore' });
 			return true;
 		} catch (e) {
 			return false;