Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
29999722
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
29999722
编写于
1月 09, 2019
作者:
M
Matt Bierner
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Don't include object key types in completeFunctionCalls
Fixes #66297
上级
45b836d0
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
9 addition
and
1 deletion
+9
-1
extensions/typescript-language-features/src/test/functionCallSnippet.test.ts
...pt-language-features/src/test/functionCallSnippet.test.ts
+8
-0
extensions/typescript-language-features/src/utils/snippetForFunctionCall.ts
...ipt-language-features/src/utils/snippetForFunctionCall.ts
+1
-1
未找到文件。
extensions/typescript-language-features/src/test/functionCallSnippet.test.ts
浏览文件 @
29999722
...
@@ -117,4 +117,12 @@ suite('typescript function call snippets', () => {
...
@@ -117,4 +117,12 @@ suite('typescript function call snippets', () => {
'
\\
$abc()$0
'
);
'
\\
$abc()$0
'
);
});
});
test
(
'
Should not include object key signature in completion, #66297
'
,
async
()
=>
{
assert
.
strictEqual
(
snippetForFunctionCall
(
{
label
:
'
foobar
'
,
},
[{
"
text
"
:
"
function
"
,
"
kind
"
:
"
keyword
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
foobar
"
,
"
kind
"
:
"
functionName
"
},
{
"
text
"
:
"
(
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
param
"
,
"
kind
"
:
"
parameterName
"
},
{
"
text
"
:
"
:
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
{
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
\n
"
,
"
kind
"
:
"
lineBreak
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
[
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
key
"
,
"
kind
"
:
"
parameterName
"
},
{
"
text
"
:
"
:
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
string
"
,
"
kind
"
:
"
keyword
"
},
{
"
text
"
:
"
]
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
:
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
string
"
,
"
kind
"
:
"
keyword
"
},
{
"
text
"
:
"
;
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
\n
"
,
"
kind
"
:
"
lineBreak
"
},
{
"
text
"
:
"
}
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
)
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
:
"
,
"
kind
"
:
"
punctuation
"
},
{
"
text
"
:
"
"
,
"
kind
"
:
"
space
"
},
{
"
text
"
:
"
void
"
,
"
kind
"
:
"
keyword
"
}]
).
snippet
.
value
,
'
foobar(${1:param})$0
'
);
});
});
});
extensions/typescript-language-features/src/utils/snippetForFunctionCall.ts
浏览文件 @
29999722
...
@@ -68,7 +68,7 @@ function getParameterListParts(
...
@@ -68,7 +68,7 @@ function getParameterListParts(
break
;
break
;
case
PConst
.
DisplayPartKind
.
parameterName
:
case
PConst
.
DisplayPartKind
.
parameterName
:
if
(
parenCount
===
1
&&
isInMethod
)
{
if
(
parenCount
===
1
&&
braceCount
===
0
&&
isInMethod
)
{
// Only take top level paren names
// Only take top level paren names
const
next
=
displayParts
[
i
+
1
];
const
next
=
displayParts
[
i
+
1
];
// Skip optional parameters
// Skip optional parameters
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录