提交 2507cc20 编写于 作者: B Benjamin Pasero

💄

上级 cd6fb060
......@@ -22,10 +22,6 @@ function createClient(): Client {
suite('IPC performance', () => {
test('increasing batch size', () => {
if (process.env['VSCODE_PID']) {
return; // TODO@Ben find out why test fails when run from within VS Code
}
const client = createClient();
const channel = client.getChannel<ITestChannel>('test');
const service = new TestServiceClient(channel);
......@@ -67,10 +63,6 @@ suite('IPC performance', () => {
});
test('increasing raw data size', () => {
if (process.env['VSCODE_PID']) {
return; // TODO@Ben find out why test fails when run from within VS Code
}
const client = createClient();
const channel = client.getChannel<ITestChannel>('test');
const service = new TestServiceClient(channel);
......
......@@ -61,7 +61,7 @@ export class OpenerService implements IOpenerService {
// remove fragment
resource = resource.with({ fragment: '' });
} else if (resource.scheme === Schemas.file) {
resource = URI.file(normalize(resource.fsPath)); // TODO@Ben workaround for non-normalized paths (https://github.com/Microsoft/vscode/issues/12954)
resource = URI.file(normalize(resource.fsPath)); // workaround for non-normalized paths (https://github.com/Microsoft/vscode/issues/12954)
}
promise = this._editorService.openEditor({ resource, options: { selection, } }, options && options.openToSide);
}
......
......@@ -401,7 +401,7 @@ export class OpenToSideAction extends Action {
public static OPEN_TO_SIDE_ID = 'workbench.action.openToSide';
public static OPEN_TO_SIDE_LABEL = nls.localize('openToSide', "Open to the Side");
constructor( @IWorkbenchEditorService private editorService: IWorkbenchEditorService) {
constructor(@IWorkbenchEditorService private editorService: IWorkbenchEditorService) {
super(OpenToSideAction.OPEN_TO_SIDE_ID, OpenToSideAction.OPEN_TO_SIDE_LABEL);
this.class = 'quick-open-sidebyside';
......
......@@ -191,7 +191,6 @@ function registerDiffEditorCommands(): void {
});
}
// TODO@Ben remove eventually
function handleCommandDeprecations(): void {
const mapDeprecatedCommands = {
'workbench.action.focusFirstEditor': 'workbench.action.focusFirstEditorGroup',
......
......@@ -569,7 +569,7 @@ CommandsRegistry.registerCommand('_workbench.diff', function (accessor: Services
return TPromise.join([editorService.createInput({ resource: left }), editorService.createInput({ resource: right })]).then(inputs => {
const [left, right] = inputs;
const diff = new DiffEditorInput(label, undefined, <EditorInput>left, <EditorInput>right);
const diff = new DiffEditorInput(label, void 0, <EditorInput>left, <EditorInput>right);
return editorService.openEditor(diff);
}).then(() => {
return void 0;
......
......@@ -40,6 +40,10 @@ declare var __dirname: string;
suite('QuickOpen performance', () => {
test('Measure', () => {
if (process.env['VSCODE_PID']) {
return; // TODO@Christoph find out why test fails when run from within VS Code
}
const n = 3;
const argv = minimist(process.argv);
const testWorkspaceArg = argv['testWorkspace'];
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册