提交 1cc381c7 编写于 作者: D Dirk Baeumer

Fixed failing test

上级 6b4fec91
...@@ -849,7 +849,7 @@ namespace CommandConfiguration { ...@@ -849,7 +849,7 @@ namespace CommandConfiguration {
result.args = []; result.args = [];
for (let arg of config.args) { for (let arg of config.args) {
let converted = ShellString.from(arg); let converted = ShellString.from(arg);
if (converted) { if (converted !== void 0) {
result.args.push(converted); result.args.push(converted);
} else { } else {
context.problemReporter.error(nls.localize('ConfigurationParser.inValidArg', 'Error: command argument must either be a string or a quoted string. Provided value is:\n{0}', context.problemReporter.error(nls.localize('ConfigurationParser.noargs', 'Error: command arguments must be an array of strings. Provided value is:\n{0}', arg ? JSON.stringify(arg, undefined, 4) : 'undefined')))); context.problemReporter.error(nls.localize('ConfigurationParser.inValidArg', 'Error: command argument must either be a string or a quoted string. Provided value is:\n{0}', context.problemReporter.error(nls.localize('ConfigurationParser.noargs', 'Error: command arguments must be an array of strings. Provided value is:\n{0}', arg ? JSON.stringify(arg, undefined, 4) : 'undefined'))));
......
...@@ -1648,7 +1648,6 @@ suite('Bugs / regression tests', () => { ...@@ -1648,7 +1648,6 @@ suite('Bugs / regression tests', () => {
} }
}); });
/*
test('Bug 28489', () => { test('Bug 28489', () => {
let external = { let external = {
version: '0.1.0', version: '0.1.0',
...@@ -1674,5 +1673,4 @@ suite('Bugs / regression tests', () => { ...@@ -1674,5 +1673,4 @@ suite('Bugs / regression tests', () => {
runtime(Tasks.RuntimeType.Shell); runtime(Tasks.RuntimeType.Shell);
testConfiguration(external, builder); testConfiguration(external, builder);
}); });
*/
}); });
\ No newline at end of file
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册