debt - slice once, loop once, sort once instead of three loops, three new arrays, and two sorts

src/vs/workbench/browser/parts/statusbar/statusbarPart.ts

@@ -115,17 +115,29 @@ export class StatusbarPart extends Part implements IStatusbarService {
 		// Fill in initial items that were contributed from the registry
 		const registry = Registry.as<IStatusbarRegistry>(Extensions.Statusbar);
 
-		const leftDescriptors = registry.items.filter(d => d.alignment === StatusbarAlignment.LEFT).sort((a, b) => b.priority - a.priority);
-		const rightDescriptors = registry.items.filter(d => d.alignment === StatusbarAlignment.RIGHT).sort((a, b) => a.priority - b.priority);
+		const descriptors = registry.items.slice().sort((a, b) => {
+			if (a.alignment === b.alignment) {
+				if (a.alignment === StatusbarAlignment.LEFT) {
+					return b.priority - a.priority;
+				} else {
+					return a.priority - b.priority;
+				}
+			} else if (a.alignment === StatusbarAlignment.LEFT) {
+				return 1;
+			} else if (a.alignment === StatusbarAlignment.RIGHT) {
+				return -1;
+			} else {
+				return 0;
+			}
+		});
 
-		const descriptors = rightDescriptors.concat(leftDescriptors); // right first because they float
-		descriptors.forEach(descriptor => {
+		for (const descriptor of descriptors) {
 			const item = this.instantiationService.createInstance(descriptor.syncDescriptor);
 			const el = this.doCreateStatusItem(descriptor.alignment, descriptor.priority);
 
 			this._register(item.render(el));
 			this.statusItemsContainer.appendChild(el);
-		});
+		}
 
 		return this.statusItemsContainer;
 	}