提交 12a0b0e7 编写于 作者: I isidor

repl: fix smoke test, make sure to get proper state when becomes visible

上级 ccdbbe13
...@@ -30,7 +30,6 @@ import { IInstantiationService, createDecorator } from 'vs/platform/instantiatio ...@@ -30,7 +30,6 @@ import { IInstantiationService, createDecorator } from 'vs/platform/instantiatio
import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage'; import { IStorageService, StorageScope } from 'vs/platform/storage/common/storage';
import { ReplExpressionsRenderer, ReplExpressionsController, ReplExpressionsDataSource, ReplExpressionsActionProvider, ReplExpressionsAccessibilityProvider } from 'vs/workbench/parts/debug/electron-browser/replViewer'; import { ReplExpressionsRenderer, ReplExpressionsController, ReplExpressionsDataSource, ReplExpressionsActionProvider, ReplExpressionsAccessibilityProvider } from 'vs/workbench/parts/debug/electron-browser/replViewer';
import { Panel } from 'vs/workbench/browser/panel'; import { Panel } from 'vs/workbench/browser/panel';
import { IPanelService } from 'vs/workbench/services/panel/common/panelService';
import { IThemeService } from 'vs/platform/theme/common/themeService'; import { IThemeService } from 'vs/platform/theme/common/themeService';
import { clipboard } from 'electron'; import { clipboard } from 'electron';
import { ICodeEditor } from 'vs/editor/browser/editorBrowser'; import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
...@@ -100,7 +99,6 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati ...@@ -100,7 +99,6 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati
@ITelemetryService telemetryService: ITelemetryService, @ITelemetryService telemetryService: ITelemetryService,
@IInstantiationService private instantiationService: IInstantiationService, @IInstantiationService private instantiationService: IInstantiationService,
@IStorageService private storageService: IStorageService, @IStorageService private storageService: IStorageService,
@IPanelService private panelService: IPanelService,
@IThemeService protected themeService: IThemeService, @IThemeService protected themeService: IThemeService,
@IModelService private modelService: IModelService, @IModelService private modelService: IModelService,
@IContextKeyService private contextKeyService: IContextKeyService, @IContextKeyService private contextKeyService: IContextKeyService,
...@@ -116,9 +114,10 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati ...@@ -116,9 +114,10 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati
private registerListeners(): void { private registerListeners(): void {
this._register(this.debugService.getViewModel().onDidFocusSession(session => { this._register(this.debugService.getViewModel().onDidFocusSession(session => {
this.selectSession(session); if (this.isVisible()) {
this.selectSession(session);
}
})); }));
this._register(this.panelService.onDidPanelOpen(() => this.refreshReplElements(true)));
this._register(this.debugService.onDidNewSession(() => this.updateTitleArea())); this._register(this.debugService.onDidNewSession(() => this.updateTitleArea()));
this._register(this.themeService.onThemeChange(() => { this._register(this.themeService.onThemeChange(() => {
if (this.isVisible()) { if (this.isVisible()) {
...@@ -263,15 +262,13 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati ...@@ -263,15 +262,13 @@ export class Repl extends Panel implements IPrivateReplService, IHistoryNavigati
this.refreshReplElements(session.getReplElements().length === 0); this.refreshReplElements(session.getReplElements().length === 0);
}); });
if (this.tree && this.isVisible() && this.tree.getInput() !== session) { if (this.tree && this.tree.getInput() !== session) {
this.tree.setInput(session); this.tree.setInput(session);
} }
} }
this.replInput.updateOptions({ readOnly: this.isReadonly }); this.replInput.updateOptions({ readOnly: this.isReadonly });
if (this.isVisible()) { this.updateInputDecoration();
this.updateInputDecoration();
}
} }
clearRepl(): void { clearRepl(): void {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册