提交 0c3b6d63 编写于 作者: M Martin Aeschlimann

Move overwriteBefore/overwriteAfter to ISuggestion #1191 - remove ISuggest.textEdit

上级 b1ea9107
...@@ -395,8 +395,6 @@ export interface ISuggestion { ...@@ -395,8 +395,6 @@ export interface ISuggestion {
noAutoAccept?: boolean; noAutoAccept?: boolean;
overwriteBefore?: number; overwriteBefore?: number;
overwriteAfter?: number; overwriteAfter?: number;
textEdit?: EditorCommon.ISingleEditOperation;
} }
export interface ISuggestResult { export interface ISuggestResult {
......
...@@ -59,33 +59,6 @@ export function suggest(model: IModel, position: IPosition, triggerCharacter: st ...@@ -59,33 +59,6 @@ export function suggest(model: IModel, position: IPosition, triggerCharacter: st
incomplete: suggestResult.incomplete, incomplete: suggestResult.incomplete,
suggestions: suggestResult.suggestions suggestions: suggestResult.suggestions
} }
const defaultRange: IRange = {
startLineNumber: position.lineNumber,
startColumn: position.column,
endLineNumber: position.lineNumber,
endColumn: position.column
};
for (let suggestion of suggestResult.suggestions) {
if (!suggestion.textEdit) {
suggestion.textEdit = {
text: suggestion.codeSnippet,
range: defaultRange
};
if (typeof suggestion.overwriteBefore === 'number' && suggestion.overwriteBefore > 0 || typeof suggestion.overwriteAfter === 'number' && suggestion.overwriteAfter > 0) {
suggestion.textEdit.range = {
startLineNumber: position.lineNumber,
startColumn: position.column - suggestion.overwriteBefore || 0,
endLineNumber: position.lineNumber,
endColumn: position.column + suggestion.overwriteAfter || 0
}
}
}
}
// add additional properties
mixin(suggestions2, suggestResult, false);
result.push(suggestions2); result.push(suggestions2);
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册