Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
053ee8ed
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
053ee8ed
编写于
3月 27, 2020
作者:
R
rebornix
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix #93600. Make notebook editor layout/insert/delete actions async.
上级
a1f7a1ad
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
23 addition
and
7 deletion
+23
-7
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
+1
-1
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
+18
-6
src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts
...rkbench/contrib/notebook/browser/view/notebookCellList.ts
+4
-0
未找到文件。
src/vs/workbench/contrib/notebook/browser/notebookBrowser.ts
浏览文件 @
053ee8ed
...
...
@@ -155,7 +155,7 @@ export interface INotebookEditor {
/**
* Layout the cell with a new height
*/
layoutNotebookCell
(
cell
:
ICellViewModel
,
height
:
number
):
void
;
layoutNotebookCell
(
cell
:
ICellViewModel
,
height
:
number
):
Promise
<
void
>
;
/**
* Render the output in webview layer
...
...
src/vs/workbench/contrib/notebook/browser/notebookEditor.ts
浏览文件 @
053ee8ed
...
...
@@ -564,7 +564,7 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
//#endregion
//#region Cell operations
layoutNotebookCell
(
cell
:
ICellViewModel
,
height
:
number
)
{
async
layoutNotebookCell
(
cell
:
ICellViewModel
,
height
:
number
):
Promise
<
void
>
{
let
relayout
=
(
cell
:
ICellViewModel
,
height
:
number
)
=>
{
let
index
=
this
.
notebookViewModel
!
.
getViewCellIndex
(
cell
);
if
(
index
>=
0
)
{
...
...
@@ -572,9 +572,13 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
}
};
let
r
:
()
=>
void
;
DOM
.
scheduleAtNextAnimationFrame
(()
=>
{
relayout
(
cell
,
height
);
r
();
});
return
new
Promise
(
resolve
=>
{
r
=
resolve
;
});
}
async
insertNotebookCell
(
cell
:
ICellViewModel
,
type
:
CellKind
,
direction
:
'
above
'
|
'
below
'
,
initialText
:
string
=
''
):
Promise
<
void
>
{
...
...
@@ -589,9 +593,13 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
newCell
.
editState
=
CellEditState
.
Editing
;
}
let
r
:
()
=>
void
;
DOM
.
scheduleAtNextAnimationFrame
(()
=>
{
this
.
list
?.
revealInCenterIfOutsideViewport
(
insertIndex
);
r
();
});
return
new
Promise
(
resolve
=>
{
r
=
resolve
;
});
}
async
deleteNotebookCell
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
...
...
@@ -600,26 +608,30 @@ export class NotebookEditor extends BaseEditor implements INotebookEditor {
this
.
notebookViewModel
!
.
deleteCell
(
index
,
true
);
}
moveCellDown
(
cell
:
ICellViewModel
):
void
{
async
moveCellDown
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
const
index
=
this
.
notebookViewModel
!
.
getViewCellIndex
(
cell
);
const
newIdx
=
index
+
1
;
this
.
moveCellToIndex
(
index
,
newIdx
);
return
this
.
moveCellToIndex
(
index
,
newIdx
);
}
moveCellUp
(
cell
:
ICellViewModel
):
void
{
async
moveCellUp
(
cell
:
ICellViewModel
):
Promise
<
void
>
{
const
index
=
this
.
notebookViewModel
!
.
getViewCellIndex
(
cell
);
const
newIdx
=
index
-
1
;
this
.
moveCellToIndex
(
index
,
newIdx
);
return
this
.
moveCellToIndex
(
index
,
newIdx
);
}
private
moveCellToIndex
(
index
:
number
,
newIdx
:
number
):
void
{
private
async
moveCellToIndex
(
index
:
number
,
newIdx
:
number
):
Promise
<
void
>
{
if
(
!
this
.
notebookViewModel
!
.
moveCellToIdx
(
index
,
newIdx
,
true
))
{
return
;
}
let
r
:
()
=>
void
;
DOM
.
scheduleAtNextAnimationFrame
(()
=>
{
this
.
list
?.
revealInCenterIfOutsideViewport
(
index
+
1
);
r
();
});
return
new
Promise
(
resolve
=>
{
r
=
resolve
;
});
}
editNotebookCell
(
cell
:
CellViewModel
):
void
{
...
...
src/vs/workbench/contrib/notebook/browser/view/notebookCellList.ts
浏览文件 @
053ee8ed
...
...
@@ -306,6 +306,10 @@ export class NotebookCellList extends WorkbenchList<CellViewModel> implements ID
}
private
_revealInternal
(
index
:
number
,
ignoreIfInsideViewport
:
boolean
,
revealPosition
:
CellRevealPosition
)
{
if
(
index
>=
this
.
view
.
length
)
{
return
;
}
const
scrollTop
=
this
.
view
.
getScrollTop
();
const
wrapperBottom
=
scrollTop
+
this
.
view
.
renderHeight
;
const
elementTop
=
this
.
view
.
elementTop
(
index
);
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录