提交 04a94d18 编写于 作者: J Joao Moreno

smoke: --sticky-quickopen cli option

上级 16ad2b78
......@@ -40,6 +40,7 @@ export interface ParsedArgs {
'enable-proposed-api'?: string | string[];
'open-url'?: string | string[];
'skip-getting-started'?: boolean;
'sticky-quickopen'?: boolean;
}
export const IEnvironmentService = createDecorator<IEnvironmentService>('environmentService');
......
......@@ -46,7 +46,8 @@ const options: minimist.Opts = {
'list-extensions',
'show-versions',
'nolazy',
'skip-getting-started'
'skip-getting-started',
'sticky-quickopen'
],
alias: {
add: 'a',
......
......@@ -111,6 +111,7 @@ export class QuickOpenController extends Component implements IQuickOpenService
@IInstantiationService private instantiationService: IInstantiationService,
@IPartService private partService: IPartService,
@IListService private listService: IListService,
@IEnvironmentService private environmentService: IEnvironmentService,
@IThemeService themeService: IThemeService
) {
super(QuickOpenController.ID, themeService);
......@@ -138,7 +139,11 @@ export class QuickOpenController extends Component implements IQuickOpenService
}
private updateConfiguration(settings: IWorkbenchQuickOpenConfiguration): void {
this.closeOnFocusLost = settings.workbench && settings.workbench.quickOpen && settings.workbench.quickOpen.closeOnFocusLost;
if (this.environmentService.args['sticky-quickopen']) {
this.closeOnFocusLost = false;
} else {
this.closeOnFocusLost = settings.workbench && settings.workbench.quickOpen && settings.workbench.quickOpen.closeOnFocusLost;
}
}
public get onShow(): Event<void> {
......
......@@ -121,8 +121,13 @@ export class SpectronApplication {
}
args.push(this._workspace);
// Prevent 'Getting Started' web page from opening on clean user-data-dir
args.push('--skip-getting-started');
// Prevent Quick Open from closing when focus is stolen, this allows concurrent smoketest suite running
args.push('--sticky-quickopen');
// Ensure that running over custom extensions directory, rather than picking up the one that was used by a tester previously
args.push(`--extensions-dir=${EXTENSIONS_DIR}`);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册