• C
    debug: use only js-debug auto attach, collapse settings · cda3fbe7
    Connor Peet 提交于
    This PR removes the hook in node-debug's auto attach, and uses only
    js-debug auto attach. As referenced in the linked issues, this involves
    removing `debug.javascript.usePreviewAutoAttach` and collapsing
    `debug.node.autoAttach` into `debug.javascript.autoAttachFilter`. The
    latter option gains a new state: `disabled`. Since there's no runtime
    cost to having auto attach around, there is now no distinct off versus
    disabled state.
    
    The status bar item and the `Debug: Toggle Auto Attach` command now
    open a quickpick, which looks like this:
    
    ![](https://memes.peet.io/img/20-09-9d2b6c0a-8b3f-4481-b2df-0753c54ee02b.png)
    
    The current setting value is selected in the quickpick. If there is a
    workspace setting for auto attach, the quickpick toggle the setting
    there by default. Otherwise (as in the image) it will target the user
    settings. The targeting is more explicit and defaults to the user
    instead of the workspace, which should help reduce confusion (#97087).
    Selecting the "scope change" item will reopen the quickpick in that
    location.
    
    Aside from the extra options for the `disabled` state in js-debug's
    contributions, there's no changes required to it or its interaction
    with debug-auto-launch.
    
    Side note: I really wanted a separator between the states and the
    scope change item, but this is not possible from an extension #74967.
    
    Fixes https://github.com/microsoft/vscode/issues/105883
    Fixes https://github.com/microsoft/vscode-js-debug/issues/732 (the rest of it)
    Fixes https://github.com/microsoft/vscode/issues/105963
    Fixes https://github.com/microsoft/vscode/issues/97087
    cda3fbe7
package.nls.json 183 字节