- Rather fun one here. The Lock code relies on assuming that Thread.interrupted() is clear on entry
- If it then sees Thread.interrupted() set, it will interrupt the current thread in order to set the
  flag again.
- Executor is a thread that does funky things with an overridden interrupt method
- Executor.abortResult() is used to track a build be interrupted or aborted in some other way
- As a result the abortResult can cause a deadlockif there is a genuine interruption
- This fix clears the interrupt flag in abortResult() and uses the write lock in order to ensure:
    - The same lock as used in interrupt() is helf
    - The interrupt flag is clear
- Clearing the interrupt flag should be safe as the only time it is called is immediately after
  an interruption and the resulting exception is caught and rethrown/logged anyway

(cherry picked from commit ddb0a472)

(cherry picked from commit ae20c037)

(cherry picked from commit ce862f0b)

(cherry picked from commit 7db618e6)

- Typo
- Print error combined
- Set result only when phase like in other code parts.
- Test for expected error message in log

(cherry picked from commit 161a0092)

- Print publisher display name instead of class, so user can understand what publisher in UI was used and failed.
- Setter for artifact archiver shows how it handle status
- Minor typos
- Added test for stacktraces in build log

(cherry picked from commit 92734a83)

(cherry picked from commit 625a22e6)

(cherry picked from commit c6d4204a)

(cherry picked from commit c569036f)

Simple `<l:task post="true" href="someurl"/>` triggers post request as expected
but then proceeds to href as normal link to. If the URL accepts GET then request
is sent twice it if does not after POSTing on background user get
'POST is required' error.

(cherry picked from commit baa19249)

Squashed commits:
[73308b5] [FIXED JENKINS-27549] job loading can be broken by a NPE in a build trigger

(cherry picked from commit 4c0d3ac6)

(cherry picked from commit 17116a21)

[JENKINS-28419] - Direct unit tests for JenkinsLocationConfiguration::adminAddress setter and getter

(cherry picked from commit dab392f8)

[JENKINS-28446] - Introduce new API method in Queue to optimize the performance of UnlabeledLoadStatistics

(cherry picked from commit 7697bdb4)

This implementation does not create new methods in API, hence it can be backported.

(cherry picked from commit 294ce778)

(cherry picked from commit 43b06626)

Just to prevent similar misuses in the future.

(cherry picked from commit 298e3713)

(cherry picked from commit 35eb8ac9)

The contract for JnlpAgentReceiver in case of error on a claimed node is
to call handshake.error() but still return true so other handlers don't
take another crack a it.

Also added unit tests DefaultJnlpSlaveReceiver.

(cherry picked from commit 2d452b6e)

(cherry picked from commit f7c0a49b)

In e91782e7 some help files were removed
from core because they were moved to LDAP plugin.
Unfortunately, these help files are not available in LDAP plugin
versions prior to 1.11.
(cherry picked from commit 824662a8)

return an empty list when called with maxLines = 0
added unit test for getLog(0) returning an empty list

(cherry picked from commit 75f58103)

[JENKINS-26781] Backport to 1.609

Using @Restricted(NoExternalUse.class) rather than @since for backported API additions (as opposed to b62a07c0).

Given the minefield that is databinding, that seems prudent.
(cherry picked from commit 8e0cbbc9)

Starting in 4f24a027 (1.587-SNAPSHOT, before #1443 or stapler #39), nestedDescribableOverridingId passes.
nestedDescribableSharingClass fails given {stapler-class: D3, kind: d3a}.
(Stapler has no way of interpreting kind since it knows nothing of Descriptor, only implementation class names.)
In master (3080573a), both fail in the way reported (only kind is passed in).
After adding stapler-class back, nestedDescribableOverridingId passes again.
(cherry picked from commit 1f41bec8)

(cherry picked from commit ef2b6580)

(cherry picked from commit 972db2a5)

newInstancesFromHeteroList should recover gracefully from the case that both kind and $class are missing.
(cherry picked from commit 17a88352)

(cherry picked from commit 343382b9)

(cherry picked from commit f4ddac10)

(cherry picked from commit 3c4b1e63)

(cherry picked from commit 4e2efcda)

(cherry picked from commit 37167d5f)

(cherry picked from commit 8dd079a8)

(cherry picked from commit 33923db1)

(cherry picked from commit c4c72598)