- also correct a bad annotation in Run

This way, it is guaranteed Jenkins.save() has never been called before
the SetupWizard is executed, and computation of the initial Setup Wizard
state will be correct.

Since the SetupWizard is now executed before reaching the COMPLETED
milestone, a Jenkins.save() call has been added in order to persist any
configuration change done in prior phases.

(cherry picked from commit 9f599911)

https://wiki.jenkins.io/display/JENKINS/Features+controlled+by+system+properties

This way, it is guaranteed Jenkins.save() has never been called before
the SetupWizard is executed, and computation of the initial Setup Wizard
state will be correct.

Since the SetupWizard is now executed before reaching the COMPLETED
milestone, a Jenkins.save() call has been added in order to persist any
configuration change done in prior phases.

Add necessary code to fix tests, and make the UI readonly.

Test (almost) only: checking the previous behaviour is preserved, and
the system property is accounted for when set.

* [JENKINS-47439] Add a failing test

On first startup, the setup wizard goes into state NEW and the filter to
force display the setup wizard is installed.

On second startup, the setup wizard goes into state RESTART (which
assumes the setup wizard is done), and the setup wizard is skipped
completely.

This test expects that state NEW is retained upon restart when nothing
is done.

* [JENKINS-47439] Persist InstallState

In some cases, the heuristics to determine the current setup wizard state are
fragile. It is safer to persist the install state so that upon restart,
the setup wizard can resume where it was left off.

* Missing javadoc and since for new public methods

* s/XXX/FIXME/

* Missed that one

* Setup wizard filter should be removed when entering a state where setup is complete

* Use parameterized logging

* Improvements over previous impl

* Removed static isUsingSecurityToken. Now only determined from install
state.
* Call onInstallStateUpdate before InstallState#initializeState as the
latter can update state.

* Triggering a new build

(cherry picked from commit 30ab4481)

[JENKINS-47793] - Jenkins master and agent configuration pages do not verify negative executor numbers (#3141)

* Fixed Regexps for number & positive-number

* Progress saving

* Fix for validation

* bug fixing

* bug fixing

* Address comments

* Address comments

* Address comments from @jglick

* Whitespace cleanup

* Address comment for @jglick

* [FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items

This allows @Initializer(after=InitMilestone.JOB_LOADED) implementations
to create items safely without risking them to be removed.

* [JENKINS-47406] Add test with an initializer creating a job

* Revert "[FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items"

This reverts commit 79ce796b00fde11fda586c9c9e2b8e93a53e2b31.

* [JENKINS-47406] Reinstate the test with Jesse's solution

* Reverted this commit by mistake

Revert "Revert "[FIXES JENKINS-47406] Milestone JOB_LOADED is now attained after cleaning up obsolete items""

This reverts commit 36c499c58c83427c7b8a6d3cc5902ec26732b2c7.

* Add link to hpi sources

* Fix Mix-up after the previous merge

* Revert "[JENKINS-48447] Fixed HTTP 404 error when clicking on newView sidebar link from an other view. (#3178)"

This reverts commit 6df06fc1.

* Revert "[JENKINS-46911] createProjectFromXML not recognizing unsafe character… (#3057)"

This reverts commit ac2a1aaf.

* [JENKINS-46911] createProjectFromXML not recognizing unsafe character '/'

* Better place for testCreateProjectCheckGoodName()

* Fix failed test

* Make changes suggested on PR review.

* Remove Failure exception, instead throw IOException. Add javadoc

* [JENKINS-46911] - Add TODO according to the comment from @jtnord.

(cherry picked from commit dce450e1)

* Deprecate Jenkins.getInstance in favor of (usually) getActiveInstance.

* Introduced get() as a concise non-null accessor.

* May as well suggest rewrites of getActiveInstance too.

* [JENKINS-47439] Add a failing test

On first startup, the setup wizard goes into state NEW and the filter to
force display the setup wizard is installed.

On second startup, the setup wizard goes into state RESTART (which
assumes the setup wizard is done), and the setup wizard is skipped
completely.

This test expects that state NEW is retained upon restart when nothing
is done.

* [JENKINS-47439] Persist InstallState

In some cases, the heuristics to determine the current setup wizard state are
fragile. It is safer to persist the install state so that upon restart,
the setup wizard can resume where it was left off.

* Missing javadoc and since for new public methods

* s/XXX/FIXME/

* Missed that one

* Setup wizard filter should be removed when entering a state where setup is complete

* Use parameterized logging

* Improvements over previous impl

* Removed static isUsingSecurityToken. Now only determined from install
state.
* Call onInstallStateUpdate before InstallState#initializeState as the
latter can update state.

* Triggering a new build

* Introducing ItemGroup.allItems and similar default methods.

* Do not get me started.

JENKINS-12251 deprecated `ITEM_FULLNAME` in favour of `ITEM_FULL_NAME`.. for new installs we should default to the correct variable

* Add ExtensionList#lookupFirst convenience method

* Fix Javadoc

* Convert to lookupSingleton, which throws unless there's only 1

* Address review comments

[FIXED JENKINS-47139] Do not set Jenkins.version too early in startup, lest InstallUtil.getLastExecVersion get confused.

* A test to verify JENKINS-44657 is working in core

* [JENKINS-44657] Move sub-job's buildsdir when outside of itemrootdir.

* [JENKINS-44657] Fix UsageStatisticsTest

Because we've added a test dependency that affects it.

* [JENKINS-44657] Normalize the path before comparing

* [JENKINS-44657] Use MockFolder instead of folders-plugin

for tests

* [JENKINS-44657] Document and annotate isDefaultBuildDir

* [JENKINS-44657] isDescendant doesn't throw IOException any more

* [JENKINS-44657] catch InvalidPathException and rethrow as IOException

* [Fix JENKINS-42577] Save jenkins version in Jenkins.save()

* [Fix JENKINS-42577] Fix unit test failures

This reverts commit f6ef8821.

This reverts commit dc8000cc.

* Use ClassFilter.appendDefaultFilter.

* FindBugs

* Update Jenkins Remoting to 3.11, fix reported FindBugs issues

(cherry picked from commit dc8000cc)

* Use ClassFilter.appendDefaultFilter.

* FindBugs

* Update Jenkins Remoting to 3.11, fix reported FindBugs issues