- 16 12月, 2017 1 次提交
-
-
由 Daniel Beck 提交于
-
- 12 12月, 2017 1 次提交
-
-
由 Daniel Beck 提交于
-
- 10 12月, 2017 2 次提交
-
-
由 Daniel Beck 提交于
-
由 Daniel Beck 提交于
-
- 05 12月, 2017 2 次提交
-
-
由 Daniel Beck 提交于
Translate into Simplified Chinese with creating new properties file
-
由 Jesse Glick 提交于
Only inspect direct subdirectories for Surefire reports
-
- 04 12月, 2017 2 次提交
-
-
由 Kohsuke Kawaguchi 提交于
-
由 Kohsuke Kawaguchi 提交于
-
- 03 12月, 2017 2 次提交
-
-
由 Oleg Nenashev 提交于
Document and refactor the CanonicalIdResolver extension point
-
由 Oleg Nenashev 提交于
Rethrow any kind of RuntimeException, such as errors from RobustReflectionConverter
-
- 02 12月, 2017 4 次提交
-
-
由 Oleg Nenashev 提交于
[JENKINS-48080] Setup Wizard hangs if confirm password is incorrect while creating admin user
-
由 Baptiste Mathus 提交于
[JENKINS-34855] more AtomicFileWriter test harnessing
-
由 Jesse Glick 提交于
war/src/test/js/ apparently produces war/target/surefire-reports/JasmineReport.xml without the TEST- prefix used by Surefire.
-
由 Jesse Glick 提交于
-
- 01 12月, 2017 3 次提交
-
-
由 Devin Nusbaum 提交于
* Use NIO for FilePath#chmod and IOUtils#mode * Add tests for NIO mode and chmod implementations * Add test, remove new method, and update JavaDoc * Provide system property to use native implementations of chmod and mode * Revert unrelated whitespace modification * Don't remove exception from throws and put imports in original location * Fix broken JavaDoc links * Ignore file type bits (above 0o7777) in Util#modeToPermission * Use octal for constants and don't include file type bits * Revert unnecessary changes to TarArchiverTest * Add assertion that non-permission bits are ignored by chmod * Use NIO copy with StandardCopyOption.COPY_ATTRIBUTES in copyToWithPermissions where possible * Catch InvalidPathException and convert it to IOException * Create utility method for File#toPath and use File#createDirectories after review * Remove useless calls to toAbsolutePath and getAbsoluteFile * Fix typos and use octal for constant after review * Add test for behavior of copyToWithPermission with special bits
-
由 Oleg Nenashev 提交于
* Add default implementations to deprecated methods of BuilableItem and Item. Currently the interface requires the API user to implement already deprecated methods. It does not make much sense, and the API could be simplified. * Address comments from @jglick
-
由 Jesse Glick 提交于
-
- 30 11月, 2017 1 次提交
-
-
由 Jesse Glick 提交于
-
- 29 11月, 2017 5 次提交
-
-
由 Baptiste Mathus 提交于
[JENKINS-34855] AtomicFileWriter is not Atomic
-
由 Baptiste Mathus 提交于
-
-
由 Baptiste Mathus 提交于
The path could already exist, *but* not be a directory. Nice catch James. Associated tests.
-
由 Baptiste Mathus 提交于
Not that critical, but still can keep them as we should generally be on FS that support atomic moves. Hence not enter that catch. If proved otherwise, we'll reconsider adjusting this verbosity.
-
- 28 11月, 2017 3 次提交
-
-
由 Baptiste Mathus 提交于
-
由 Oleg Nenashev 提交于
[JENKINS-47429] User.getLegacyConfigFilesFor no longer seems to be necessary
-
由 Jesse Glick 提交于
* Introducing ItemGroup.allItems and similar default methods. * Do not get me started.
-
- 27 11月, 2017 5 次提交
-
-
由 Oleg Nenashev 提交于
If task can be run only on master, use shortcut
-
由 Gentle Yang 提交于
-
由 Kohsuke Kawaguchi 提交于
-
由 Kohsuke Kawaguchi 提交于
-
由 Baptiste Mathus 提交于
It might be preferrable from a consistency standpoint, but many CLI tests start failing when you force this. So, as the previous behaviour was not forcing the sync, this seems to show there could be unintended behavioural changes in effect. Possibly, we'll want to address this later, but as the main goal here was to make commit() atomic as much as possible, fixing this is probably another story anyway. Note: I was *never* able to reproduce those failures on my machine in a normal env dev. It was only visible in CI. I finally managed to make it reproducible (but still a bit randomly) by using Docker resource constraints, using something like this: * cd to jenkins local clone * `docker run -ti -v m2repo:/root/.m2/repository -v $PWD:/work -v ~/.m2/settings.xml:/root/.m2/settings.xml:ro -v ~/.m2/settings-security.xml:/root/.m2/settings-security.xml:ro --device-write-iops /dev/mapper/fedora-home:40 --device-read-iops /dev/mapper/fedora-home:40 --device-write-bps /dev/mapper/fedora-home:10m --device-read-bps /dev/mapper/fedora-home:10m maven:3.5.2-jdk-8 bash` * cd /work * `mvn clean install -Dtest=WaitNodeOfflineCommandTest,RunRangeCommandTest -Dfindbugs.skip=true -DfailIfNoTests=false -Dskip.npm=true` Failure example: ``` ERROR] Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 55.68OfflineCommandTest [ERROR] waitNodeOfflineShouldSucceedOnDisconnectingNode(hudson.cli.WaitNodeOf <<< FAILURE! java.lang.AssertionError: Expected: <true> but: was <false> at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20) at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8) at hudson.cli.WaitNodeOfflineCommandTest.waitNodeOfflineShouldSucceedndTest.java:128) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorIm at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAc at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framew at org.junit.internal.runners.model.ReflectiveCallable.run(Reflective at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framewor at org.junit.internal.runners.statements.InvokeMethod.evaluate(Invoke at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefor at org.jvnet.hudson.test.JenkinsRule$1.evaluate(JenkinsRule.java:542) at org.junit.internal.runners.statements.FailOnTimeout$CallableStatem at org.junit.internal.runners.statements.FailOnTimeout$CallableStatem at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.lang.Thread.run(Thread.java:748) [ERROR] waitNodeOfflineShouldSucceedOnDisconnectedNode(hudson.cli.WaitNodeOff <<< FAILURE! java.lang.AssertionError ```
-
- 26 11月, 2017 5 次提交
-
-
由 Oleg Nenashev 提交于
* [JENKINS-48157] - Reproduce the issue in test * [JENKINS-48157] - Annotate and document nullness conditions in MyViewsProperty and ViewGroupMixIn * [FIXED JENKINS-48157] - Prevent NPEs when using public API and when using null primaryViewName * [JENKINS-48157] - Fix typo in Javadoc
-
由 Oleg Nenashev 提交于
Disable flaky SetupWizardTest#shouldDisableUnencrypterProtocolsByDefault()
-
由 Oleg Nenashev 提交于
Introducing AccessControlled.hasPermission(Authentication, Permission)
-
由 Oleg Nenashev 提交于
[JENKINS-48116] - Restore AbstractTaskListener binary compatibility in the core.
-
由 Oleg Nenashev 提交于
Cache permission id to avoid allocating of new strings
-
- 25 11月, 2017 1 次提交
-
-
由 Gentle Yang 提交于
-
- 24 11月, 2017 1 次提交
-
-
由 Baptiste Mathus 提交于
I see we enter that catch, and the `else` in a failing test. But I'm somewhat stuck since I miss both the stack, and even at least the exception being thrown and not being an `AtomicMoveNotSupportedException`. It's possibly an `IOException` or some subclass. But still having the stack could help understand why the test fails, and provide more data for diagnosis in the future in production use. ``` === Starting hudson.cli.RunRangeCommandTest 0.007 [id=96] WARNING o.jvnet.hudson.test.JenkinsRule#before: Jenkins.theInstance was not cleared by a previous test, doing that now 0.018 [id=96] INFO o.jvnet.hudson.test.JenkinsRule#createWebServer: Running on http://localhost:45833/jenkins/ 0.037 [id=15] WARNING jenkins.model.Jenkins#cleanUp: This instance is no longer the singleton, ignoring cleanUp() 0.345 [id=96] WARNING hudson.util.AtomicFileWriter#commit: Unable to move atomically, falling back to non-atomic move. 0.345 [id=96] SEVERE hudson.util.AtomicFileWriter#commit: Unable to move /home/jenkins/workspace/Core_jenkins_PR-2548-5VRJ4BBBSEGVOZEA7OVAL2YLTLCBL55RB4LDQIZN56WJZD4M6ZKA/test/target/jenkinsTests.tmp/jenkins333129509690162870test/atomic9184049448662376708tmp to /home/jenkins/workspace/Core_jenkins_PR-2548-5VRJ4BBBSEGVOZEA7OVAL2YLTLCBL55RB4LDQIZN56WJZD4M6ZKA/test/target/jenkinsTests.tmp/jenkins333129509690162870test/secret.key. Attempting to delete /home/jenkins/workspace/Core_jenkins_PR-2548-5VRJ4BBBSEGVOZEA7OVAL2YLTLCBL55RB4LDQIZN56WJZD4M6ZKA/test/target/jenkinsTests.tmp/jenkins333129509690162870test/atomic9184049448662376708tmp and abandoning. ```
-
- 23 11月, 2017 2 次提交
-
-
由 Daniel Beck 提交于
misc UX changes
-
由 Baptiste Mathus 提交于
Should make the test more robust on variously performing setups.
-