Factored out common code into applyErrorMessage function.

war/src/main/webapp/scripts/hudson-behavior.js

@@ -167,12 +167,7 @@ var FormChecker = {
         this.sendRequest(next.url, {
             method : next.method,
             onComplete : function(x) {
-                var i;
-                next.target.innerHTML = x.status==200 ? x.responseText
-                    : '<a href="" onclick="document.getElementById(\'valerr' + (i=iota++)
-                    + '\').style.display=\'block\';return false">ERROR</a><div id="valerr'
-                    + i + '" style="display:none">' + x.responseText + '</div>';
-                Behaviour.applySubtree(next.target);
+                applyErrorMessage(next.target, x);
                 FormChecker.inProgress--;
                 FormChecker.schedule();
                 layoutUpdateCallback.call();
@@ -2194,12 +2189,7 @@ function validateButton(checkUrl,paramList,button) {
       parameters: parameters,
       onComplete: function(rsp) {
           spinner.style.display="none";
-          var i;
-          target.innerHTML = rsp.status==200 ? rsp.responseText
-                : '<a href="" onclick="document.getElementById(\'valerr' + (i=iota++)
-                + '\').style.display=\'block\';return false">ERROR</a><div id="valerr'
-                + i + '" style="display:none">' + rsp.responseText + '</div>';
-          Behaviour.applySubtree(target);
+          applyErrorMessage(target, rsp);
           layoutUpdateCallback.call();
           var s = rsp.getResponseHeader("script");
           try {
@@ -2211,6 +2201,15 @@ function validateButton(checkUrl,paramList,button) {
   });
 }
 
+function applyErrorMessage(elt, rsp) {
+    var i;
+    elt.innerHTML = rsp.status==200 ? rsp.responseText
+        : '<a href="" onclick="document.getElementById(\'valerr' + (i=iota++)
+        + '\').style.display=\'block\';return false">ERROR</a><div id="valerr'
+        + i + '" style="display:none">' + rsp.responseText + '</div>';
+    Behaviour.applySubtree(elt);
+}
+
 // create a combobox.
 // @param idOrField
 //      ID of the <input type=text> element that becomes a combobox, or the field itself.