Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
dfc2fe38
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
dfc2fe38
编写于
4月 18, 2011
作者:
K
Kohsuke Kawaguchi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FIXED JENKINS-9367] persistence problem in View$PropertyList
上级
eb7292e1
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
31 addition
and
9 deletion
+31
-9
changelog.html
changelog.html
+3
-1
core/src/main/java/hudson/model/ListView.java
core/src/main/java/hudson/model/ListView.java
+2
-1
core/src/main/java/hudson/model/View.java
core/src/main/java/hudson/model/View.java
+16
-7
test/src/test/java/hudson/model/ViewTest.java
test/src/test/java/hudson/model/ViewTest.java
+10
-0
未找到文件。
changelog.html
浏览文件 @
dfc2fe38
...
...
@@ -55,7 +55,9 @@ Upcoming changes</a>
<!-- Record your changes in the trunk here. -->
<div
id=
"trunk"
style=
"display:none"
>
<!--=TRUNK-BEGIN=-->
<ul
class=
image
>
<li
class=
>
<li
class=
bug
>
Fixed a persistence problem in
<tt>
View$PropertyList
</tt>
(
<a
href=
"http://issues.jenkins-ci.org/browse/JENKINS-9367"
>
issue 9367
</a>
)
</ul>
</div>
<!--=TRUNK-END=-->
...
...
core/src/main/java/hudson/model/ListView.java
浏览文件 @
dfc2fe38
...
...
@@ -91,7 +91,8 @@ public class ListView extends View implements Saveable {
this
.
owner
=
owner
;
}
private
Object
readResolve
()
{
protected
Object
readResolve
()
{
super
.
readResolve
();
if
(
includeRegex
!=
null
)
includePattern
=
Pattern
.
compile
(
includeRegex
);
initColumns
();
...
...
core/src/main/java/hudson/model/View.java
浏览文件 @
dfc2fe38
...
...
@@ -118,7 +118,7 @@ public abstract class View extends AbstractModelObject implements AccessControll
* List of {@link ViewProperty}s configured for this view.
* @since 1.406
*/
private
volatile
DescribableList
<
ViewProperty
,
ViewPropertyDescriptor
>
properties
=
new
PropertyList
();
private
volatile
DescribableList
<
ViewProperty
,
ViewPropertyDescriptor
>
properties
=
new
PropertyList
(
this
);
protected
View
(
String
name
)
{
this
.
name
=
name
;
...
...
@@ -129,9 +129,11 @@ public abstract class View extends AbstractModelObject implements AccessControll
this
.
owner
=
owner
;
}
pr
ivate
Object
readResolve
()
{
pr
otected
Object
readResolve
()
{
if
(
properties
==
null
)
{
properties
=
new
PropertyList
();
properties
=
new
PropertyList
(
this
);
}
else
{
properties
.
setOwner
(
this
);
}
return
this
;
}
...
...
@@ -762,15 +764,22 @@ public abstract class View extends AbstractModelObject implements AccessControll
return
v
;
}
private
class
PropertyList
extends
DescribableList
<
ViewProperty
,
ViewPropertyDescriptor
>
{
private
PropertyList
()
{
super
(
View
.
this
);
public
static
class
PropertyList
extends
DescribableList
<
ViewProperty
,
ViewPropertyDescriptor
>
{
private
PropertyList
(
View
owner
)
{
super
(
owner
);
}
public
PropertyList
()
{
// needed for XStream deserialization
}
public
View
getOwner
()
{
return
(
View
)
owner
;
}
@Override
protected
void
onModified
()
throws
IOException
{
for
(
ViewProperty
p
:
this
)
p
.
setView
(
View
.
this
);
p
.
setView
(
getOwner
()
);
}
}
}
test/src/test/java/hudson/model/ViewTest.java
浏览文件 @
dfc2fe38
...
...
@@ -118,4 +118,14 @@ public class ViewTest extends HudsonTestCase {
assertNull
(
p
.
getView
(
"list"
));
}
@Bug
(
9367
)
public
void
testPersistence
()
throws
Exception
{
ListView
view
=
new
ListView
(
"foo"
,
hudson
);
hudson
.
addView
(
view
);
ListView
v
=
(
ListView
)
Hudson
.
XSTREAM
.
fromXML
(
Hudson
.
XSTREAM
.
toXML
(
view
));
System
.
out
.
println
(
v
.
getProperties
());
assertNotNull
(
v
.
getProperties
());
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录