Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
d513253d
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
d513253d
编写于
11月 11, 2013
作者:
O
Oliver Gondža
提交者:
root
11月 11, 2013
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Tidy up after #1005
上级
a494868c
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
16 addition
and
49 deletion
+16
-49
core/src/main/java/hudson/cli/CLIAction.java
core/src/main/java/hudson/cli/CLIAction.java
+1
-1
core/src/main/java/jenkins/model/Jenkins.java
core/src/main/java/jenkins/model/Jenkins.java
+0
-1
test/src/test/groovy/hudson/cli/CLIActionTest.groovy
test/src/test/groovy/hudson/cli/CLIActionTest.groovy
+15
-2
test/src/test/java/hudson/cli/CLIActionTest.java
test/src/test/java/hudson/cli/CLIActionTest.java
+0
-45
未找到文件。
core/src/main/java/hudson/cli/CLIAction.java
浏览文件 @
d513253d
...
...
@@ -68,7 +68,7 @@ public class CLIAction implements UnprotectedRootAction, StaplerProxy {
}
public
String
getUrlName
()
{
return
"
/
cli"
;
return
"cli"
;
}
public
void
doCommand
(
StaplerRequest
req
,
StaplerResponse
rsp
)
throws
ServletException
,
IOException
{
...
...
core/src/main/java/jenkins/model/Jenkins.java
浏览文件 @
d513253d
...
...
@@ -3667,7 +3667,6 @@ public class Jenkins extends AbstractCIBase implements ModifiableTopLevelItemGro
||
rest
.
startsWith
(
"/tcpSlaveAgentListener"
)
// TODO SlaveComputer.doSlaveAgentJnlp; there should be an annotation to request unprotected access
||
rest
.
matches
(
"/computer/[^/]+/slave-agent[.]jnlp"
)
&&
"true"
.
equals
(
Stapler
.
getCurrentRequest
().
getParameter
(
"encrypt"
))
||
rest
.
startsWith
(
"/cli"
)
||
rest
.
startsWith
(
"/federatedLoginService/"
)
||
rest
.
startsWith
(
"/securityRealm"
))
return
this
;
// URLs that are always visible without READ permission
...
...
test/src/test/groovy/hudson/cli/CLIActionTest.groovy
浏览文件 @
d513253d
package
hudson.cli
import
hudson.remoting.Channel
import
hudson.security.FullControlOnceLoggedInAuthorizationStrategy
;
import
org.junit.Rule
import
org.junit.Test
import
org.jvnet.hudson.test.JenkinsRule
import
org.jvnet.hudson.test.HudsonTestCase.WebClient
;
import
java.util.concurrent.ExecutorService
import
java.util.concurrent.Executors
/**
*
*
* @author Kohsuke Kawaguchi
* @author christ66
*/
class
CLIActionTest
{
@Rule
...
...
@@ -33,4 +35,15 @@ class CLIActionTest {
pool
.
shutdown
();
}
}
@Test
public
void
serveCliActionToAnonymousUser
()
throws
Exception
{
def
wc
=
j
.
createWebClient
();
wc
.
goTo
(
"cli"
);
// Verify user can see cli before security
j
.
jenkins
.
setSecurityRealm
(
j
.
createDummySecurityRealm
());
j
.
jenkins
.
setAuthorizationStrategy
(
new
FullControlOnceLoggedInAuthorizationStrategy
());
wc
.
goTo
(
"cli"
);
// and after security enabled.
}
}
test/src/test/java/hudson/cli/CLIActionTest.java
已删除
100644 → 0
浏览文件 @
a494868c
/*
* The MIT License
*
* Copyright (c) 2013 christ66
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package
hudson.cli
;
import
hudson.security.FullControlOnceLoggedInAuthorizationStrategy
;
import
org.jvnet.hudson.test.HudsonTestCase
;
/**
* A Test unit to verify that CLIAction has .
*
* @author christ66
*/
public
class
CLIActionTest
extends
HudsonTestCase
{
public
void
testCliActionUnprotectedRootActionTest
()
throws
Exception
{
WebClient
wc
=
createWebClient
();
wc
.
goTo
(
"cli"
);
// Verify user can see cli before security
jenkins
.
setSecurityRealm
(
createDummySecurityRealm
());
jenkins
.
setAuthorizationStrategy
(
new
FullControlOnceLoggedInAuthorizationStrategy
());
wc
.
goTo
(
"cli"
);
// and after security enabled.
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录