apparently not quite working, but trying to suppress "even if unstable" option...

apparently not quite working, but trying to suppress "even if unstable" option for the promoted builds plugin.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5642 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/java/hudson/tasks/BuildTrigger.java

@@ -193,6 +193,11 @@ public class BuildTrigger extends Publisher {
             return true;
         }
 
+        public boolean showEvenIfUnstableOption(AbstractProject p) {
+            // UGLY: for promotion process, this option doesn't make sense. 
+            return !p.getClass().getName().contains("PromotionProcess");
+        }
+
         /**
          * Form validation method.
          */

core/src/main/resources/hudson/tasks/BuildTrigger/config.jelly

@@ -3,8 +3,10 @@
 	  <f:textbox name="buildTrigger.childProjects" value="${instance.childProjectsValue}"
       checkUrl="'${rootURL}/publisher/BuildTrigger/check?value='+escape(this.value)"/>
 	</f:entry>
-  <f:entry title="">
-    <f:checkbox id="buildTrigger.evenIfUnstable" name="buildTrigger.evenIfUnstable" checked="${instance.threshold.toString()=='UNSTABLE'}" />
-    <label for="buildTrigger.evenIfUnstable">Trigger even if the build is unstable</label>
-  </f:entry>
+  <j:if test="${descriptor.showEvenIfUnstableOption(it)}">
+    <f:entry title="">
+      <f:checkbox id="buildTrigger.evenIfUnstable" name="buildTrigger.evenIfUnstable" checked="${instance.threshold.toString()=='UNSTABLE'}" />
+      <label for="buildTrigger.evenIfUnstable">Trigger even if the build is unstable</label>
+    </f:entry>
+  </j:if>
 </j:jelly>
\ No newline at end of file