Merge pull request #4244 from res0nance/misc-cleanups

Misc cleanups

core/src/main/java/hudson/ClassicPluginStrategy.java

@@ -289,7 +289,7 @@ public class ClassicPluginStrategy implements PluginStrategy {
     protected ClassLoader createClassLoader(List<File> paths, ClassLoader parent, Attributes atts) throws IOException {
         if (atts != null) {
             String usePluginFirstClassLoader = atts.getValue( "PluginFirstClassLoader" );
-            if (Boolean.valueOf( usePluginFirstClassLoader )) {
+            if (Boolean.parseBoolean( usePluginFirstClassLoader )) {
                 PluginFirstClassLoader classLoader = new PluginFirstClassLoader();
                 classLoader.setParentFirst( false );
                 classLoader.setParent( parent );

core/src/main/java/hudson/Util.java

@@ -905,10 +905,10 @@ public class Util {
                 }
 
                 byte[] bytes = new String(new int[] { codePoint }, 0, 1).getBytes(StandardCharsets.UTF_8);
-                for(int j=0;j<bytes.length;j++) {
+                for (byte aByte : bytes) {
                     out.append('%');
-                    out.append(toDigit((bytes[j] >> 4) & 0xF));
-                    out.append(toDigit(bytes[j] & 0xF));
+                    out.append(toDigit((aByte >> 4) & 0xF));
+                    out.append(toDigit(aByte & 0xF));
                 }
 
                 if(Character.charCount(codePoint) > 1) {

core/src/main/java/hudson/model/BooleanParameterDefinition.java

@@ -65,7 +65,7 @@ public class BooleanParameterDefinition extends SimpleParameterDefinition {
     }
 
     public ParameterValue createValue(String value) {
-        return new BooleanParameterValue(getName(),Boolean.valueOf(value),getDescription());
+        return new BooleanParameterValue(getName(),Boolean.parseBoolean(value),getDescription());
     }
 
     @Override

core/src/main/java/hudson/model/DirectoryBrowserSupport.java

@@ -181,7 +181,7 @@ public final class DirectoryBrowserSupport implements HttpResponse {
         }
 
         String path = getPath(req);
-        if(path.replace('\\','/').indexOf("/../")!=-1) {
+        if(path.replace('\\', '/').contains("/../")) {
             // don't serve anything other than files in the artifacts dir
             rsp.sendError(HttpServletResponse.SC_BAD_REQUEST);
             return;

core/src/main/java/jenkins/model/Configuration.java

@@ -31,7 +31,7 @@ public class Configuration {
 
     public static boolean getBooleanConfigParameter(String name, boolean defaultValue) {
         String value = getStringConfigParameter(name,null);
-        return (value==null)?defaultValue:Boolean.valueOf(value);
+        return (value==null)?defaultValue:Boolean.parseBoolean(value);
     }
 
     public static String getStringConfigParameter(String name, String defaultValue) {

core/src/main/java/jenkins/security/FrameOptionsPageDecorator.java

@@ -15,5 +15,5 @@ import org.kohsuke.accmod.restrictions.NoExternalUse;
 @Extension(ordinal = 1000) @Symbol("frameOptions")
 public class FrameOptionsPageDecorator extends PageDecorator {
     @Restricted(NoExternalUse.class)
-    public static boolean enabled = Boolean.valueOf(SystemProperties.getString(FrameOptionsPageDecorator.class.getName() + ".enabled", "true"));
+    public static boolean enabled = Boolean.parseBoolean(SystemProperties.getString(FrameOptionsPageDecorator.class.getName() + ".enabled", "true"));
 }

core/src/main/java/jenkins/util/AntClassLoader.java

@@ -365,9 +365,9 @@ public class AntClassLoader extends ClassLoader implements SubBuildListener {
         if (classpath != null) {
             Path actualClasspath = classpath.concatSystemClasspath("ignore");
             String[] pathElements = actualClasspath.list();
-            for (int i = 0; i < pathElements.length; ++i) {
+            for (String pathElement : pathElements) {
                 try {
-                    addPathElement(pathElements[i]);
+                    addPathElement(pathElement);
                 } catch (BuildException e) {
                     // ignore path elements which are invalid
                     // relative to the project