JENKINS-8702 improve unit tests. UpdateCenterTest depends on online resource...

JENKINS-8702 improve unit tests. UpdateCenterTest depends on online resource and takes too long. Fix this

core/src/test/java/hudson/model/UpdateCenterTest.java

@@ -36,16 +36,13 @@ import java.net.URL;
  * @author Kohsuke Kawaguchi
  */
 public class UpdateCenterTest extends TestCase {
-    public void testData() throws IOException {
-        // check if we have the internet connectivity. See HUDSON-2095
-        try {
-            new URL("http://updates.hudson-labs.org/").openStream();
-        } catch (IOException e) {
-            System.out.println("Skipping this test. No internet connectivity");
-            return;
-        }
 
-        URL url = new URL("http://updates.hudson-labs.org/update-center.json?version=build");
+    private URL getDataFileURL(String name) {
+        return UpdateCenterTest.class.getResource(name);
+    }
+
+    public void testData() throws IOException {
+        URL url = getDataFileURL("light_update-center.json?version=build"); // we use the "light" version to speed things up.
         String jsonp = IOUtils.toString(url.openStream());
         String json = jsonp.substring(jsonp.indexOf('(')+1,jsonp.lastIndexOf(')'));
 

core/src/test/resources/hudson/model/light_update-center.json?version=build

+updateCenter.post(
+{
+  "connectionCheckUrl": "http://www.google.com/",
+  "core":   {
+    "buildDate": "Jan 21, 2011",
+    "name": "core",
+    "url": "http://updates.hudson-labs.org/download/war/1.395/hudson.war",
+    "version": "1.395"
+  },
+  "id": "default",
+  "plugins":   {
+    "rake":     {
+      "buildDate": "Oct 30, 2010",
+      "dependencies": [],
+      "developers": [      {
+        "developerId": "david_calavera",
+        "email": "calavera@apache.org",
+        "name": "David Calavera"
+      }],
+      "excerpt": "This plugin allows Hudson to invoke <a href='http://rake.rubyforge.org'>Rake<\/a> tasks as build steps.",
+      "labels": ["builder"],
+      "name": "rake",
+      "previousTimestamp": "2010-10-28T22:18:02.00Z",
+      "previousVersion": "1.7.2",
+      "releaseTimestamp": "2010-10-30T16:33:22.00Z",
+      "requiredCore": "1.376",
+      "scm": "github.com",
+      "title": "Rake plugin",
+      "url": "http://updates.hudson-labs.org/download/plugins/rake/1.7.3/rake.hpi",
+      "version": "1.7.3",
+      "wiki": "http://wiki.hudson-ci.org//display/HUDSON/Rake+plugin"
+    },
+    "rebuild":     {
+      "buildDate": "Sep 15, 2010",
+      "dependencies": [],
+      "developers": [      {
+        "developerId": "ragesh_nair",
+        "email": "ragesh.x.nair@sonyericsson.com",
+        "name": "Ragesh Nair"
+      }],
+      "excerpt": "This plugin allows the user to _rebuild_ a _parameterized build_ without entering the _parameters_ again.",
+      "labels": ["misc"],
+      "name": "rebuild",
+      "previousTimestamp": "2010-07-16T20:17:48.00Z",
+      "previousVersion": "1.1",
+      "releaseTimestamp": "2010-09-15T14:07:48.00Z",
+      "requiredCore": "1.354",
+      "scm": "svn.dev.java.net",
+      "title": "Rebuild Plugin",
+      "url": "http://updates.hudson-labs.org/download/plugins/rebuild/1.4/rebuild.hpi",
+      "version": "1.4",
+      "wiki": "http://wiki.hudson-ci.org//display/HUDSON/Rebuild+Plugin"
+    },
+  },
+  "signature":   {
+    "certificates": ["MIIE8jCCA9qgAwIBAgIBBjANBgkqhkiG9w0BAQUFADCBojELMAkGA1UEBhMCVVMxEzARBgNVBAgTCkNhbGlmb3JuaWExFDASBgNVBAcTC1NhbnRhIENsYXJhMRcwFQYDVQQKEw5IdWRzb24gcHJvamVjdDEXMBUGA1UECxMOSHVkc29uIFJvb3QgQ0ExFzAVBgNVBAMTDkh1ZHNvbiBSb290IENBMR0wGwYJKoZIhvcNAQkBFg5odWRzb25Ac3VuLmNvbTAeFw0xMDA0MTgyMzQzMzhaFw0xMTA0MTgyMzQzMzhaMIGVMQswCQYDVQQGEwJVUzETMBEGA1UECBMKQ2FsaWZvcm5pYTERMA8GA1UEBxMIU2FuIEpvc2UxDzANBgNVBAoTBkh1ZHNvbjEPMA0GA1UECxMGSHVkc29uMR0wGwYDVQQDExRIdWRzb24gVXBkYXRlIENlbnRlcjEdMBsGCSqGSIb3DQEJARYOa2tAa29oc3VrZS5vcmcwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDUQ7uN/ZQvyHvi5UONr2CAmWfWiAPPqaF4SS7dTIaLM/sxRgnZY1k7zt/8MTce7gNOd2EyCru93EgMVY1ivEH4b9fYSlzSnu8Lx2RdMulW0iqinLY17Jv+J1qxq+tRUyMa9y3DN28sf7ydLcpEJog3Of6KL+zJlKQS0oNcgsju9LdfzccmMu8Qq3lNhtcdsPkcRWpHyGiyva99xXBR/pqxM0GR8aMZYNwLi59Vg8/fpkTLwhBGVOgEIdO4ARvH/HTlfaLdr2pJ5BfsODk7A3VHV2ObDYIa+skEy1PPvtLv3/TfI/nD9Owt/TlpyI5aAbd1lboUrsPNyKjiR6GIfOcFAgMBAAGjggE8MIIBODAJBgNVHRMEAjAAMB0GA1UdDgQWBBSMP/tadXU+XdrmlxxDSCZeyMAcbDCB1wYDVR0jBIHPMIHMgBRRpkLqhXylaDmRPhWgCQ0fl62cX6GBqKSBpTCBojELMAkGA1UEBhMCVVMxEzARBgNVBAgTCkNhbGlmb3JuaWExFDASBgNVBAcTC1NhbnRhIENsYXJhMRcwFQYDVQQKEw5IdWRzb24gcHJvamVjdDEXMBUGA1UECxMOSHVkc29uIFJvb3QgQ0ExFzAVBgNVBAMTDkh1ZHNvbiBSb290IENBMR0wGwYJKoZIhvcNAQkBFg5odWRzb25Ac3VuLmNvbYIJAImLL4rgC+O7MDIGCWCGSAGG+EIBBAQlFiNodHRwOi8vaHVkc29uLWNpLm9yZy9odWRzb24tY3JsLnBlbTANBgkqhkiG9w0BAQUFAAOCAQEADs3NHx8j+x45msMgjHPoMb4yvz42vI1ea4UyYHrDZGlEsK7kfVbNHNpt+UGZaws0b+f6brL/3DA9w0niCTucHMd+ZqqFGpXHvV/IVVrR7omLgQ6EdinYYDXzIl/1Z97jeRDmL4/kckxxGyTyw/Y4/YatmVSM8ZESY3W9lYS9P90I+Jmo0e4W6tY+ztPrsw3C3ixmvfqG++YQTjZivr/5sCUd6UJHAz7XuX9Eqgyz2Od1wOazmtP7TEsQVEwiJXGB5HFLw7qtC51K3VdAj43nm+qgKe0U3yOw57EYKlntQzCWF24ucOZ1QhpvrIlzcD1q4AlIdlTD0OtuP9uGIYCTjA=="],
+    "digest": "5GfPwsLf4xDFFg4/g4r4WofnS70=",
+    "signature": "SKTyc4xy6OV2+ClP/4edsGGJv/E8qcR+gyAB/HUvfztB+9D2DiHLJAQVXx0PnPQZeHB1sZnNfEEH/gGg0cf7lfJBIU6fIMGrqzoAIQvTxG7ZNgjhba/+ojDjM222R8Sy19hGws4/pO4d+W9CwRSNNz8FZqGPxnV4k21IfQ9QF8lxCguetXzWX2edJT2fr4j32bFtbDxfsUdYNc4D6F8/8BScQpoHgBNVqLa8oWRUpn6qae2hfLXkAixeHlDDNbEZWuQ7g/kmXrn5COf0vVH4Jrr1L8QzVvifjrVbM55UZl2tv/EExUJXYeVUJMmA1wmvpwbr+6Pr9tIeKsq51sqTVw=="
+  },
+  "updateCenterVersion": "1"
+}
+);