Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
b400d150
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
b400d150
编写于
3月 07, 2015
作者:
K
Kohsuke Kawaguchi
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FIXED JENKINS-27277]
上级
2ba1f8fa
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
45 addition
and
6 deletion
+45
-6
changelog.html
changelog.html
+3
-1
core/src/main/java/hudson/security/TokenBasedRememberMeServices2.java
...n/java/hudson/security/TokenBasedRememberMeServices2.java
+42
-5
未找到文件。
changelog.html
浏览文件 @
b400d150
...
...
@@ -55,7 +55,9 @@ Upcoming changes</a>
<!-- Record your changes in the trunk here. -->
<div
id=
"trunk"
style=
"display:none"
>
<!--=TRUNK-BEGIN=-->
<ul
class=
image
>
<li
class=
>
<li
class=
rfe
>
As security hardening, mark "remember me" cookie as HTTP only
(
<a
href=
"https://issues.jenkins-ci.org/browse/JENKINS-27277"
>
issue 27277
</a>
)
</ul>
</div>
<!--=TRUNK-END=-->
...
...
core/src/main/java/hudson/security/TokenBasedRememberMeServices2.java
浏览文件 @
b400d150
/*
* The MIT License
*
*
* Copyright (c) 2004-2009, Sun Microsystems, Inc., Kohsuke Kawaguchi
*
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
...
...
@@ -35,9 +35,13 @@ import org.acegisecurity.userdetails.UserDetailsService;
import
org.apache.commons.codec.binary.Base64
;
import
org.springframework.util.Assert
;
import
javax.servlet.http.Cookie
;
import
javax.servlet.http.HttpServletRequest
;
import
javax.servlet.http.HttpServletResponse
;
import
java.lang.reflect.InvocationTargetException
;
import
java.lang.reflect.Method
;
import
java.util.Date
;
import
java.util.logging.Level
;
/**
* {@link TokenBasedRememberMeServices} with modification so as not to rely
...
...
@@ -128,8 +132,41 @@ public class TokenBasedRememberMeServices2 extends TokenBasedRememberMeServices
}
}
/**
@Override
protected
Cookie
makeValidCookie
(
String
tokenValueBase64
,
HttpServletRequest
request
,
long
maxAge
)
{
Cookie
cookie
=
super
.
makeValidCookie
(
tokenValueBase64
,
request
,
maxAge
);
// if we can mark the cookie HTTP only, do so to protect this cookie even in case of XSS vulnerability.
if
(
SET_HTTP_ONLY
!=
null
)
{
try
{
SET_HTTP_ONLY
.
invoke
(
cookie
,
true
);
}
catch
(
IllegalAccessException
e
)
{
// ignore
}
catch
(
InvocationTargetException
e
)
{
// ignore
}
}
// if the user is running Jenkins over HTTPS, we also want to prevent the cookie from leaking in HTTP.
// whether the login is done over HTTPS or not would be a good enough approximation of whether Jenkins runs in
// HTTPS or not, so use that.
if
(
request
.
isSecure
())
cookie
.
setSecure
(
true
);
return
cookie
;
}
/**
* Used to compute the token signature securely.
*/
private
static
final
HMACConfidentialKey
MAC
=
new
HMACConfidentialKey
(
TokenBasedRememberMeServices
.
class
,
"mac"
);
private
static
final
Method
SET_HTTP_ONLY
;
static
{
Method
m
=
null
;
try
{
m
=
Cookie
.
class
.
getMethod
(
"setHttpOnly"
,
boolean
.
class
);
}
catch
(
NoSuchMethodException
x
)
{
// 3.0+
}
SET_HTTP_ONLY
=
m
;
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录