Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
a7264a96
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
a7264a96
编写于
4月 29, 2016
作者:
A
Antonio Muñiz
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[SECURITY-170] More tests
上级
eb2b62e1
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
39 addition
and
2 deletion
+39
-2
core/src/main/java/hudson/model/ParametersAction.java
core/src/main/java/hudson/model/ParametersAction.java
+3
-2
test/src/test/java/hudson/model/ParametersActionTest2.java
test/src/test/java/hudson/model/ParametersActionTest2.java
+36
-0
未找到文件。
core/src/main/java/hudson/model/ParametersAction.java
浏览文件 @
a7264a96
...
...
@@ -276,8 +276,9 @@ public class ParametersAction implements RunAction2, Iterable<ParameterValue>, Q
filteredParameters
.
add
(
v
);
}
else
{
LOGGER
.
log
(
Level
.
WARNING
,
"Skipped parameter `{0}` as it is undefined on `{1}`. Set `-D{2}`=true to allow "
+
"undefined parameters to be injected as environment variables, even though it represents a security breach"
,
new
Object
[]
{
v
.
getName
(),
run
.
getParent
().
getFullName
(),
KEEP_UNDEFINED_PARAMETERS_SYSTEM_PROPERTY_NAME
});
+
"undefined parameters to be injected as environment variables or `-D{3}=[comma-separated list]` to whitelist specific parameter names, "
+
"even though it represents a security breach"
,
new
Object
[]
{
v
.
getName
(),
run
.
getParent
().
getFullName
(),
KEEP_UNDEFINED_PARAMETERS_SYSTEM_PROPERTY_NAME
,
SAFE_PARAMETERS_SYSTEM_PROPERTY_NAME
});
}
}
...
...
test/src/test/java/hudson/model/ParametersActionTest2.java
浏览文件 @
a7264a96
...
...
@@ -149,6 +149,42 @@ public class ParametersActionTest2 {
}
}
@Test
@Issue
(
"SECURITY-170"
)
public
void
nonParameterizedJob
()
throws
Exception
{
FreeStyleProject
p
=
j
.
createFreeStyleProject
();
FreeStyleBuild
build
=
j
.
assertBuildStatusSuccess
(
p
.
scheduleBuild2
(
0
,
new
Cause
.
UserIdCause
(),
new
ParametersAction
(
new
StringParameterValue
(
"foo"
,
"baz"
),
new
StringParameterValue
(
"bar"
,
"bar"
)
)));
assertTrue
(
"foo parameter is not listed in getParameters"
,
!
hasParameterWithName
(
build
.
getAction
(
ParametersAction
.
class
),
"foo"
));
assertTrue
(
"bar parameter is not listed in getParameters"
,
!
hasParameterWithName
(
build
.
getAction
(
ParametersAction
.
class
),
"bar"
));
}
@Test
@Issue
(
"SECURITY-170"
)
public
void
nonParameterizedJobButWhitelisted
()
throws
Exception
{
FreeStyleProject
p
=
j
.
createFreeStyleProject
();
try
{
System
.
setProperty
(
ParametersAction
.
SAFE_PARAMETERS_SYSTEM_PROPERTY_NAME
,
"foo,bar"
);
FreeStyleBuild
build2
=
j
.
assertBuildStatusSuccess
(
p
.
scheduleBuild2
(
0
,
new
Cause
.
UserIdCause
(),
new
ParametersAction
(
new
StringParameterValue
(
"foo"
,
"baz"
),
new
StringParameterValue
(
"bar"
,
"bar"
)
)));
assertTrue
(
"foo parameter is listed in getParameters"
,
hasParameterWithName
(
build2
.
getAction
(
ParametersAction
.
class
),
"foo"
));
assertTrue
(
"bar parameter is listed in getParameters"
,
hasParameterWithName
(
build2
.
getAction
(
ParametersAction
.
class
),
"bar"
));
}
finally
{
System
.
clearProperty
(
ParametersAction
.
SAFE_PARAMETERS_SYSTEM_PROPERTY_NAME
);
}
}
public
static
boolean
hasParameterWithName
(
Iterable
<
ParameterValue
>
values
,
String
name
)
{
for
(
ParameterValue
v
:
values
)
{
if
(
v
.
getName
().
equals
(
name
))
{
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录