提交 a2ff6101 编写于 作者: C christ66

[FIXED JENKINS-8815] Fixed issue where CLI required giving Overall read permission to anonymous.

Added test unit.
上级 d1833450
......@@ -31,6 +31,7 @@ import java.util.UUID;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletResponse;
import hudson.model.UnprotectedRootAction;
import jenkins.model.Jenkins;
import org.kohsuke.accmod.Restricted;
......@@ -40,7 +41,6 @@ import org.kohsuke.stapler.StaplerResponse;
import hudson.Extension;
import hudson.model.FullDuplexHttpChannel;
import hudson.model.RootAction;
import hudson.remoting.Channel;
/**
......@@ -48,7 +48,7 @@ import hudson.remoting.Channel;
*/
@Extension
@Restricted(NoExternalUse.class)
public class CLIAction implements RootAction {
public class CLIAction implements UnprotectedRootAction {
private transient final Map<UUID,FullDuplexHttpChannel> duplexChannels = new HashMap<UUID, FullDuplexHttpChannel>();
......
/*
* The MIT License
*
* Copyright (c) 2013 christ66
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*/
package hudson.cli;
import hudson.security.FullControlOnceLoggedInAuthorizationStrategy;
import org.jvnet.hudson.test.HudsonTestCase;
/**
* A Test unit to verify that CLIAction has .
*
* @author christ66
*/
public class CLIActionTest extends HudsonTestCase {
public void testCliActionUnprotectedRootActionTest() throws Exception {
WebClient wc = createWebClient();
wc.goTo("cli"); // Verify user can see cli before security
jenkins.setSecurityRealm(createDummySecurityRealm());
jenkins.setAuthorizationStrategy(new FullControlOnceLoggedInAuthorizationStrategy());
wc.goTo("cli"); // and after security enabled.
}
}
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册