Merge pull request #2894 from oleg-nenashev/bug/JENKINS-44330-LogRecorderClassloading

[FIXED JENKINS-44330] - Prevent classloading of Target comparator in LogRecorder#orderedTargets()

core/src/main/java/hudson/logging/LogRecorder.java

@@ -73,17 +73,14 @@ public class LogRecorder extends AbstractModelObject implements Saveable {
     private volatile String name;
 
     public final CopyOnWriteList<Target> targets = new CopyOnWriteList<Target>();
-
+    private final static TargetComparator TARGET_COMPARATOR = new TargetComparator();
+    
     @Restricted(NoExternalUse.class)
     Target[] orderedTargets() {
         // will contain targets ordered by reverse name length (place specific targets at the beginning)
         Target[] ts = targets.toArray(new Target[]{});
 
-        Arrays.sort(ts, new Comparator<Target>() {
-            public int compare(Target left, Target right) {
-                return right.getName().length() - left.getName().length();
-            }
-        });
+        Arrays.sort(ts, TARGET_COMPARATOR);
 
         return ts;
     }
@@ -206,6 +203,14 @@ public class LogRecorder extends AbstractModelObject implements Saveable {
         }
 
     }
+    
+    private static class TargetComparator implements Comparator<Target> {
+
+        @Override
+        public int compare(Target left, Target right) {
+            return right.getName().length() - left.getName().length();
+        }
+    }
 
     private static final class SetLevel extends MasterToSlaveCallable<Void,Error> {
         /** known loggers (kept per agent), to avoid GC */