Improved error diagnostics in the archive configuration (#1307)

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@7238 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/java/hudson/tasks/ArtifactArchiver.java

@@ -64,6 +64,12 @@ public class ArtifactArchiver extends Publisher {
     public boolean perform(AbstractBuild<?,?> build, Launcher launcher, BuildListener listener) throws InterruptedException {
         AbstractProject<?,?> p = build.getProject();
 
+        if(artifacts.length()==0) {
+            listener.error(Messages.ArtifactArchiver_NoIncludes());
+            build.setResult(Result.FAILURE);
+            return true;
+        }
+
         File dir = build.getArtifactsDir();
         dir.mkdirs();
 

core/src/main/resources/hudson/tasks/Messages.properties

@@ -3,11 +3,15 @@ Ant.ExecFailed=command execution failed.
 Ant.GlobalConfigNeeded= Maybe you need to configure where your Ant installations are?
 Ant.NotADirectory={0} is not a directory
 Ant.NotAntDirectory={0} doesn''t look like an Ant directory
-
 Ant.ProjectConfigNeeded= Maybe you need to configure the job to choose one of your Ant installations?
+
 ArtifactArchiver.DeletingOld=Deleting old artifacts from {0}
 ArtifactArchiver.DisplayName=Archive the artifacts
 ArtifactArchiver.FailedToArchive=Failed to archive artifacts: {0}
+ArtifactArchiver.NoIncludes=\
+No artifacts is configured for archiving.\n\
+You probably forgot to set the file pattern, so please go back to the configuration and specify it.\n\
+If you really do mean to archive all the files in the workspace, please specify "**/*" 
 ArtifactArchiver.NoMatchFound=No artifacts found that match the file pattern "{0}". Configuration error?
 
 BatchFile.DisplayName=Execute Windows batch command