提交 88a9e0ed 编写于 作者: K kohsuke

using Permission little more.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@6340 71c3de6d-444a-0410-be80-ed276b4c234a
上级 c614c797
...@@ -1263,8 +1263,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1263,8 +1263,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
*/ */
public synchronized void doConfigSubmit( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException { public synchronized void doConfigSubmit( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
try { try {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
req.setCharacterEncoding("UTF-8"); req.setCharacterEncoding("UTF-8");
...@@ -1399,15 +1398,13 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1399,15 +1398,13 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
} }
public synchronized void doQuietDown( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException { public synchronized void doQuietDown( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
isQuietingDown = true; isQuietingDown = true;
rsp.sendRedirect2("."); rsp.sendRedirect2(".");
} }
public synchronized void doCancelQuietDown( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException { public synchronized void doCancelQuietDown( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
isQuietingDown = false; isQuietingDown = false;
getQueue().scheduleMaintenance(); getQueue().scheduleMaintenance();
rsp.sendRedirect2("."); rsp.sendRedirect2(".");
...@@ -1668,8 +1665,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1668,8 +1665,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
* Reloads the configuration. * Reloads the configuration.
*/ */
public synchronized void doReload( StaplerRequest req, StaplerResponse rsp ) throws IOException { public synchronized void doReload( StaplerRequest req, StaplerResponse rsp ) throws IOException {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
// engage "loading ..." UI and then run the actual task in a separate thread // engage "loading ..." UI and then run the actual task in a separate thread
final ServletContext context = req.getServletContext(); final ServletContext context = req.getServletContext();
...@@ -1699,8 +1695,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1699,8 +1695,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
*/ */
public void doUploadPlugin( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException { public void doUploadPlugin( StaplerRequest req, StaplerResponse rsp ) throws IOException, ServletException {
try { try {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
ServletFileUpload upload = new ServletFileUpload(new DiskFileItemFactory()); ServletFileUpload upload = new ServletFileUpload(new DiskFileItemFactory());
...@@ -1796,8 +1791,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1796,8 +1791,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
* @since 1.161 * @since 1.161
*/ */
public void doExit( StaplerRequest req, StaplerResponse rsp ) throws IOException { public void doExit( StaplerRequest req, StaplerResponse rsp ) throws IOException {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
LOGGER.severe(String.format("Shutting down VM as requested by {0} from {1}", LOGGER.severe(String.format("Shutting down VM as requested by {0} from {1}",
getAuthentication(), req.getRemoteAddr())); getAuthentication(), req.getRemoteAddr()));
rsp.setStatus(HttpServletResponse.SC_OK); rsp.setStatus(HttpServletResponse.SC_OK);
...@@ -1821,8 +1815,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -1821,8 +1815,7 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
* Configure the logging level. * Configure the logging level.
*/ */
public void doConfigLogger( StaplerRequest req, StaplerResponse rsp, @QueryParameter("name") String name, @QueryParameter("level") String level) throws IOException { public void doConfigLogger( StaplerRequest req, StaplerResponse rsp, @QueryParameter("name") String name, @QueryParameter("level") String level) throws IOException {
if(!Hudson.adminCheck(req,rsp)) checkPermission(ADMINISTER);
return;
Logger.getLogger(name).setLevel(Level.parse(level.toUpperCase())); Logger.getLogger(name).setLevel(Level.parse(level.toUpperCase()));
rsp.sendRedirect2("log"); rsp.sendRedirect2("log");
} }
...@@ -2104,11 +2097,6 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -2104,11 +2097,6 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
return false; return false;
} }
/**
* Administrative access to Hudson.
*/
public static final Permission ADMINISTER = new Permission(Hudson.class,"Administer", Permission.WRITE);
/** /**
* Live view of recent {@link LogRecord}s produced by Hudson. * Live view of recent {@link LogRecord}s produced by Hudson.
*/ */
...@@ -2153,6 +2141,11 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node ...@@ -2153,6 +2141,11 @@ public final class Hudson extends View implements ItemGroup<TopLevelItem>, Node
private static final Pattern ICON_SIZE = Pattern.compile("\\d+x\\d+"); private static final Pattern ICON_SIZE = Pattern.compile("\\d+x\\d+");
/**
* Administrative access to Hudson.
*/
public static final Permission ADMINISTER = new Permission(Hudson.class,"Administer", Permission.CONFIGURE);
static { static {
XSTREAM.alias("hudson",Hudson.class); XSTREAM.alias("hudson",Hudson.class);
XSTREAM.alias("slave",Slave.class); XSTREAM.alias("slave",Slave.class);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册