Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
7f92a9bd
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
7f92a9bd
编写于
3月 25, 2013
作者:
J
Jesse Glick
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[JENKINS-17311] Improved hashify to detect manual skip idiom.
上级
1389cb80
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
19 addition
and
2 deletion
+19
-2
core/src/main/java/hudson/scheduler/CronTab.java
core/src/main/java/hudson/scheduler/CronTab.java
+15
-0
core/src/test/java/hudson/scheduler/CronTabTest.java
core/src/test/java/hudson/scheduler/CronTabTest.java
+4
-2
未找到文件。
core/src/main/java/hudson/scheduler/CronTab.java
浏览文件 @
7f92a9bd
...
...
@@ -29,6 +29,8 @@ import java.io.StringReader;
import
java.util.Calendar
;
import
java.util.GregorianCalendar
;
import
java.util.Locale
;
import
java.util.regex.Matcher
;
import
java.util.regex.Pattern
;
import
static
java
.
util
.
Calendar
.*;
import
javax.annotation.CheckForNull
;
...
...
@@ -451,6 +453,19 @@ public final class CronTab {
}
else
if
(
spec
.
matches
(
"\\d+ .+"
))
{
// "0 ..." (certain minute) to hash
return
"H "
+
spec
.
substring
(
spec
.
indexOf
(
' '
)
+
1
);
}
else
{
Matcher
m
=
Pattern
.
compile
(
"0(,(\\d+)(,\\d+)*)( .+)"
).
matcher
(
spec
);
if
(
m
.
matches
())
{
// 0,15,30,45 to H/15
int
period
=
Integer
.
parseInt
(
m
.
group
(
2
));
if
(
period
>
0
)
{
StringBuilder
b
=
new
StringBuilder
();
for
(
int
i
=
period
;
i
<
60
;
i
+=
period
)
{
b
.
append
(
','
).
append
(
i
);
}
if
(
b
.
toString
().
equals
(
m
.
group
(
1
)))
{
return
"H/"
+
period
+
m
.
group
(
4
);
}
}
}
return
null
;
}
}
...
...
core/src/test/java/hudson/scheduler/CronTabTest.java
浏览文件 @
7f92a9bd
...
...
@@ -176,6 +176,7 @@ public class CronTabTest {
@Test
public
void
checkSanity
()
throws
Exception
{
assertEquals
(
null
,
new
CronTab
(
"@hourly"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_do_you_really_mean_every_minute_when_you
(
"* * * * *"
,
"H * * * *"
),
new
CronTab
(
"* * * * *"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_do_you_really_mean_every_minute_when_you
(
"*/1 * * * *"
,
"H * * * *"
),
new
CronTab
(
"*/1 * * * *"
).
checkSanity
());
assertEquals
(
null
,
new
CronTab
(
"H H(0-2) * * *"
,
Hash
.
from
(
"stuff"
)).
checkSanity
());
assertEquals
(
Messages
.
CronTab_do_you_really_mean_every_minute_when_you
(
"* 0 * * *"
,
"H 0 * * *"
),
new
CronTab
(
"* 0 * * *"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_do_you_really_mean_every_minute_when_you
(
"* 6,18 * * *"
,
"H 6,18 * * *"
),
new
CronTab
(
"* 6,18 * * *"
).
checkSanity
());
...
...
@@ -183,11 +184,12 @@ public class CronTabTest {
assertEquals
(
Messages
.
CronTab_do_you_really_mean_every_minute_when_you
(
"* * 3 * *"
,
"H * 3 * *"
),
new
CronTab
(
"* * 3 * *"
).
checkSanity
());
// promote hashes:
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H/15 * * * *"
,
"*/15 * * * *"
),
new
CronTab
(
"*/15 * * * *"
).
checkSanity
());
// XXX 0,15,30,45 * * * * → H/15 * * * *
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H/15 * * * *"
,
"0,15,30,45 * * * *"
),
new
CronTab
(
"0,15,30,45 * * * *"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H * * * *"
,
"0 * * * *"
),
new
CronTab
(
"0 * * * *"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H * * * *"
,
"5 * * * *"
),
new
CronTab
(
"5 * * * *"
).
checkSanity
());
// if the user specifically asked for 3:00 AM, probably we should stick to 3:00–3:59
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H 3 * * *"
,
"0 3 * * *"
),
new
CronTab
(
"0 3 * * *"
).
checkSanity
());
assertEquals
(
Messages
.
CronTab_spread_load_evenly_by_using_rather_than_
(
"H 22 * * 6"
,
"00 22 * * 6"
),
new
CronTab
(
"00 22 * * 6"
).
checkSanity
());
assertEquals
(
null
,
new
CronTab
(
"H/15 * 1 1 *"
).
checkSanity
());
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录