提交 76d1958e 编写于 作者: D Daniel Beck

[SECURITY-245] Use US-ASCII to prevent charset issues

上级 281cd6c6
......@@ -5,6 +5,7 @@
*/
package hudson.security.csrf;
import java.nio.charset.Charset;
import java.security.MessageDigest;
import java.security.NoSuchAlgorithmException;
import java.util.logging.Level;
......@@ -96,7 +97,8 @@ public class DefaultCrumbIssuer extends CrumbIssuer {
String newCrumb = issueCrumb(request, salt);
if ((newCrumb != null) && (crumb != null)) {
// String.equals() is not constant-time, but this is
return MessageDigest.isEqual(newCrumb.getBytes(), crumb.getBytes());
return MessageDigest.isEqual(newCrumb.getBytes(Charset.forName("US-ASCII")),
crumb.getBytes(Charset.forName("US-ASCII")));
}
}
return false;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册