- fixed #899 where Hudson fails to recognize a test failure

- fixed character escape issues.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@5201 71c3de6d-444a-0410-be80-ed276b4c234a

core/src/main/java/hudson/tasks/junit/CaseResult.java

@@ -26,6 +26,10 @@ public final class CaseResult extends TestObject implements Comparable<CaseResul
     private /*final*/ int failedSince;
 
     CaseResult(SuiteResult parent, Element testCase) {
+        this(parent,testCase,testCase.attributeValue("name"));
+    }
+
+    CaseResult(SuiteResult parent, Element testCase, String testCaseName) {
         // schema for JUnit report XML format is not available in Ant,
         // so I don't know for sure what means what.
         // reports in http://www.nabble.com/difference-in-junit-publisher-and-ant-junitreport-tf4308604.html#a12265700
@@ -38,11 +42,11 @@ public final class CaseResult extends TestObject implements Comparable<CaseResul
 
         String cn = parent.getName();
         className = safe(cn);
-        testName = safe(testCase.attributeValue("name"));
+        testName = safe(testCaseName);
         errorStackTrace = getError(testCase);
     }
 
-    private String getError(Element testCase) {
+    private static String getError(Element testCase) {
         String msg = testCase.elementText("error");
         if(msg!=null)
             return msg;

core/src/main/java/hudson/tasks/junit/SuiteResult.java

@@ -47,6 +47,12 @@ public final class SuiteResult implements Serializable {
         stdout = root.elementText("system-out");
         stderr = root.elementText("system-err");
 
+        Element ex = root.element("error");
+        if(ex!=null) {
+            // according to junit-noframes.xsl l.229, this happens when the test class failed to load
+            cases.add(new CaseResult(this,root,"<init>"));
+        }
+
         for (Element e : (List<Element>)root.elements("testcase")) {
             cases.add(new CaseResult(this,e));
         }

core/src/main/resources/hudson/tasks/junit/CaseResult/index.jelly

@@ -4,10 +4,10 @@
     <l:main-panel>
       <j:set var="st" value="${it.status}" />
       <h1 class="${st.cssClass}">
-        ${st.message}
+        <st:out value="${st.message}" />
       </h1>
       <p style="font-weight:bold">
-        ${it.fullName}
+        <st:out value="${it.fullName}"/>
       </p>
       <j:if test="${!it.passed}">
         <div style="text-align:right;">

core/src/main/resources/hudson/tasks/junit/MetaTabulatedResult/body.jelly

@@ -9,7 +9,7 @@
       <j:forEach var="f" items="${it.failedTests}" varStatus="i">
         <tr>
           <td class="pane">
-            <a href="${f.getRelativePathFrom(it)}">${f.fullName}</a>
+            <a href="${f.getRelativePathFrom(it)}"><st:out value="${f.fullName}"/></a>
           </td>
           <td class="pane" style="text-align:right;">
             ${f.age}