Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
2ed0c046
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2ed0c046
编写于
4月 25, 2016
作者:
D
Daniel Beck
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[FIX SECURITY-276] Don't allow open redirect using scheme-rel. URL
上级
d6bcfdac
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
17 addition
and
3 deletion
+17
-3
core/src/main/java/hudson/Util.java
core/src/main/java/hudson/Util.java
+14
-0
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
+1
-1
core/src/main/java/hudson/model/ParametersDefinitionProperty.java
.../main/java/hudson/model/ParametersDefinitionProperty.java
+1
-1
core/src/main/java/hudson/security/AuthenticationProcessingFilter2.java
...java/hudson/security/AuthenticationProcessingFilter2.java
+1
-1
未找到文件。
core/src/main/java/hudson/Util.java
浏览文件 @
2ed0c046
...
...
@@ -77,6 +77,8 @@ import javax.annotation.CheckForNull;
import
javax.annotation.Nonnull
;
import
javax.annotation.Nullable
;
import
org.apache.commons.codec.digest.DigestUtils
;
import
org.kohsuke.accmod.Restricted
;
import
org.kohsuke.accmod.restrictions.NoExternalUse
;
/**
* Various utility methods that don't have more proper home.
...
...
@@ -1454,7 +1456,12 @@ public class Util {
* The same algorithm can be seen in {@link URI}, but
* implementing this by ourselves allow it to be more lenient about
* escaping of URI.
*
* @deprecated Use {@code isAbsoluteOrSchemeRelativeUri} instead if your goal is to prevent open redirects
*/
@Deprecated
@RestrictedSince
(
"1.651.2 / 2.TODO"
)
@Restricted
(
NoExternalUse
.
class
)
public
static
boolean
isAbsoluteUri
(
@Nonnull
String
uri
)
{
int
idx
=
uri
.
indexOf
(
':'
);
if
(
idx
<
0
)
return
false
;
// no ':'. can't be absolute
...
...
@@ -1463,6 +1470,13 @@ public class Util {
return
idx
<
_indexOf
(
uri
,
'#'
)
&&
idx
<
_indexOf
(
uri
,
'?'
)
&&
idx
<
_indexOf
(
uri
,
'/'
);
}
/**
* Return true iff the parameter denotes an absolute URI, or a scheme-relative URI.
*/
public
static
boolean
isAbsoluteOrSchemeRelativeUri
(
@Nonnull
String
uri
)
{
return
isAbsoluteUri
(
uri
)
||
uri
.
startsWith
(
"//"
);
}
/**
* Works like {@link String#indexOf(int)} but 'not found' is returned as s.length(), not -1.
* This enables more straight-forward comparison.
...
...
core/src/main/java/hudson/model/DirectoryBrowserSupport.java
浏览文件 @
2ed0c046
...
...
@@ -158,7 +158,7 @@ public final class DirectoryBrowserSupport implements HttpResponse {
String
pattern
=
req
.
getParameter
(
"pattern"
);
if
(
pattern
==
null
)
pattern
=
req
.
getParameter
(
"path"
);
// compatibility with Hudson<1.129
if
(
pattern
!=
null
&&
!
Util
.
isAbsoluteUri
(
pattern
))
{
// avoid open redirect
if
(
pattern
!=
null
&&
!
Util
.
isAbsolute
OrSchemeRelative
Uri
(
pattern
))
{
// avoid open redirect
rsp
.
sendRedirect2
(
pattern
);
return
;
}
...
...
core/src/main/java/hudson/model/ParametersDefinitionProperty.java
浏览文件 @
2ed0c046
...
...
@@ -158,7 +158,7 @@ public class ParametersDefinitionProperty extends JobProperty<Job<?, ?>>
getJob
(),
delay
.
getTime
(),
new
ParametersAction
(
values
),
new
CauseAction
(
new
Cause
.
UserIdCause
()));
if
(
item
!=
null
)
{
String
url
=
formData
.
optString
(
"redirectTo"
);
if
(
url
==
null
||
Util
.
isAbsoluteUri
(
url
))
// avoid open redirect
if
(
url
==
null
||
Util
.
isAbsolute
OrSchemeRelative
Uri
(
url
))
// avoid open redirect
url
=
req
.
getContextPath
()+
'/'
+
item
.
getUrl
();
rsp
.
sendRedirect
(
formData
.
optInt
(
"statusCode"
,
SC_CREATED
),
url
);
}
else
...
...
core/src/main/java/hudson/security/AuthenticationProcessingFilter2.java
浏览文件 @
2ed0c046
...
...
@@ -53,7 +53,7 @@ public class AuthenticationProcessingFilter2 extends AuthenticationProcessingFil
if
(
targetUrl
==
null
)
return
getDefaultTargetUrl
();
if
(
Util
.
isAbsoluteUri
(
targetUrl
))
if
(
Util
.
isAbsolute
OrSchemeRelative
Uri
(
targetUrl
))
return
"."
;
// avoid open redirect
// URL returned from determineTargetUrl() is resolved against the context path,
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录