[FIXED JENKINS-16770] missing build title in /rssAll when build has no test result

changelog.html

@@ -80,6 +80,9 @@ Upcoming changes</a>
   <li class=bug>
     UpdateCenter REST API chokes if there was a plugin installation failure.
     (<a href="https://issues.jenkins-ci.org/browse/JENKINS-16836">issue 16836</a>)
+  <li class=bug>
+    Missing build title in /rssAll when build has no test result.
+    (<a href="https://issues.jenkins-ci.org/browse/JENKINS-16770">issue 16770</a>)
   <li class=rfe>
     JNLP slave installers can now work transparently with secured Jenkins.
     (SECURITY-54 / despite the ticket marker, this is not a security vulnerability)

core/src/main/java/hudson/model/Run.java

@@ -1834,7 +1834,7 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
                     return new Summary(worseOverride != null ? worseOverride : true,
                             Messages.Run_Summary_TestFailures(trN.getFailCount()));
             } else {
-                if(trN.getFailCount()!= 0) {
+                if(trN!=null && trN.getFailCount()!= 0) {
                     if(trP.getFailCount()==0)
                         return new Summary(worseOverride != null ? worseOverride : true,
                                 Messages.Run_Summary_TestsStartedToFail(trN.getFailCount()));

core/src/test/java/hudson/model/BuildStatusSummaryTest.java

@@ -178,6 +178,28 @@ public class BuildStatusSummaryTest {
         assertTrue(summary.isWorse);
         assertEquals(Messages.Run_Summary_TestsStartedToFail(1), summary.message);
     }
+
+    @Test
+    public void testBuildGotNoTests() {
+        // previous build has no tests at all
+        mockBuilds(AbstractBuild.class);
+
+        when(this.build.getResult()).thenReturn(Result.UNSTABLE);
+        when(this.prevBuild.getResult()).thenReturn(Result.UNSTABLE);
+        // Null test result action recorded
+        when(((AbstractBuild) this.build).getTestResultAction()).thenReturn(null);
+
+        Summary summary = this.build.getBuildStatusSummary();
+
+        assertFalse(summary.isWorse);
+        assertEquals(Messages.Run_Summary_Unstable(), summary.message);
+
+        // same thing should happen if previous build has tests, but no failing ones:
+        buildHasTestResult((AbstractBuild) this.prevBuild, 0);
+        summary = this.build.getBuildStatusSummary();
+        assertFalse(summary.isWorse);
+        assertEquals(Messages.Run_Summary_Unstable(), summary.message);
+    }
     
     @Test
     public void testBuildEqualAmountOfTestsFailing() {