[JENKINS-22839] Style changes after feedback

core/src/main/java/hudson/logging/LogRecorder.java

@@ -31,6 +31,7 @@ import hudson.Util;
 import hudson.XmlFile;
 import hudson.model.AbstractModelObject;
 import hudson.model.Computer;
+import hudson.util.HttpResponses;
 import jenkins.model.Jenkins;
 import hudson.model.Saveable;
 import hudson.model.TaskListener;
@@ -44,6 +45,7 @@ import hudson.util.RingBufferLogHandler;
 import hudson.util.XStream2;
 import net.sf.json.JSONObject;
 import org.kohsuke.stapler.DataBoundConstructor;
+import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.StaplerRequest;
 import org.kohsuke.stapler.StaplerResponse;
 import org.kohsuke.stapler.interceptor.RequirePOST;
@@ -298,9 +300,9 @@ public class LogRecorder extends AbstractModelObject implements Saveable {
     }
 
     @RequirePOST
-    public void doClear(StaplerRequest req, StaplerResponse rsp) throws IOException {
+    public HttpResponse doClear() throws IOException {
         handler.clear();
-        rsp.sendRedirect2(".");
+        return HttpResponses.redirectToDot();
     }
 
     /**

core/src/test/java/hudson/logging/LogRecorderTest.java

@@ -24,6 +24,7 @@
 
 package hudson.logging;
 
+import java.io.IOException;
 import java.util.logging.Level;
 import java.util.logging.LogRecord;
 import org.junit.Test;
@@ -54,7 +55,7 @@ public class LogRecorderTest {
         assertFalse(matches("", "hudson.model.Hudson", Level.FINE));
     }
 
-    @Test public void testClearing() {
+    @Test public void testClearing() throws IOException {
         LogRecorder lr = new LogRecorder("foo");
         LogRecorder.Target t = new LogRecorder.Target("", Level.FINE);
         lr.targets.add(t);
@@ -62,11 +63,11 @@ public class LogRecorderTest {
         LogRecord record = createLogRecord("jenkins", Level.INFO, "message");
         lr.handler.publish(record);
         assertEquals(lr.handler.getView().get(0), record);
-        assertTrue(lr.handler.getView().size() == 1);
+        assertEquals(1, lr.handler.getView().size());
 
-        lr.handler.clear();
+        lr.doClear();
 
-        assertTrue(lr.handler.getView().size() == 0);
+        assertEquals(0, lr.handler.getView().size());
     }
 
     @Test public void testSpecificExclusion() {