during the unit test, exceptions in prototype.js Ajax.Request callback...

during the unit test, exceptions in prototype.js Ajax.Request callback handlers are treated as fatal problems.

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@28238 71c3de6d-444a-0410-be80-ed276b4c234a

test/src/test/java/hudson/ExceptionTest.java

+package hudson;
+
+import com.gargoylesoftware.htmlunit.ScriptException;
+import org.jvnet.hudson.test.HudsonTestCase;
+
+/**
+ * @author Kohsuke Kawaguchi
+ */
+public class ExceptionTest extends HudsonTestCase {
+    /**
+     * Makes sure that an AJAX handler error results in a fatal problem in the unit test.
+     */
+    public void testAjaxError() throws Exception {
+        try {
+            createWebClient().goTo("/self/ajaxError");
+            fail("should have resulted in a ScriptException");
+        } catch (ScriptException e) {
+            if (e.getMessage().contains("simulated error"))
+                return; // as expected
+            throw e;
+
+        }
+    }
+}

test/src/test/resources/hudson/ExceptionTest/ajaxError.jelly

+<!--
+The MIT License
+
+Copyright (c) 2004-2010, Sun Microsystems, Inc.
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in
+all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+-->
+
+<!--
+  Entrance to the configuration page
+-->
+<j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:s="/lib/form">
+<l:layout title="Nodes">
+  <l:main-panel>
+    <script>
+      new Ajax.Request("./ajaxError", {
+        onComplete: function() {
+          throw "simulated error"; // simulated failure in AJAX call handling
+        }
+      });
+    </script>
+  </l:main-panel>
+</l:layout>
+</j:jelly>
\ No newline at end of file

war/resources/scripts/hudson-behavior.js

@@ -1783,3 +1783,11 @@ function createComboBox(id,valueFunction) {
         }
     });
 }
+
+
+if (isRunAsTest) {
+    // during the unit test, make Ajax errors fatal
+    Ajax.Request.prototype.dispatchException = function(e) {
+        throw e;
+    }
+}