Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
jenkins
提交
00064be3
J
jenkins
项目概览
xxadev
/
jenkins
与 Fork 源项目一致
从无法访问的项目Fork
通知
3
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
J
jenkins
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
00064be3
编写于
9月 10, 2019
作者:
W
Wadeck Follonier
提交者:
Daniel Beck
9月 10, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
[SECURITY-1525]
上级
df600eb7
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
57 addition
and
1 deletion
+57
-1
test/src/test/java/lib/form/ComboBoxSEC1525Test.java
test/src/test/java/lib/form/ComboBoxSEC1525Test.java
+50
-0
test/src/test/resources/lib/form/ComboBoxSEC1525Test/XssProperty/config.jelly
...ces/lib/form/ComboBoxSEC1525Test/XssProperty/config.jelly
+6
-0
war/src/main/webapp/scripts/combobox.js
war/src/main/webapp/scripts/combobox.js
+1
-1
未找到文件。
test/src/test/java/lib/form/ComboBoxSEC1525Test.java
0 → 100644
浏览文件 @
00064be3
package
lib.form
;
import
com.gargoylesoftware.htmlunit.html.HtmlElement
;
import
com.gargoylesoftware.htmlunit.html.HtmlElementUtil
;
import
com.gargoylesoftware.htmlunit.html.HtmlPage
;
import
hudson.model.FreeStyleProject
;
import
hudson.model.Job
;
import
hudson.util.ComboBoxModel
;
import
jenkins.model.OptionalJobProperty
;
import
org.jvnet.hudson.test.HudsonTestCase
;
import
org.jvnet.hudson.test.Issue
;
import
org.jvnet.hudson.test.TestExtension
;
//TODO meant to be merged back into ComboBoxTest after security release to avoid conflict during the upmerge process
public
class
ComboBoxSEC1525Test
extends
HudsonTestCase
{
public
static
class
XssProperty
extends
OptionalJobProperty
<
Job
<?,?>>
{
@TestExtension
(
"testEnsureXSSnotPossible"
)
public
static
class
DescriptorImpl
extends
OptionalJobProperty
.
OptionalJobPropertyDescriptor
{
@Override
public
String
getDisplayName
()
{
return
"XSS Property"
;
}
public
ComboBoxModel
doFillXssItems
()
{
return
new
ComboBoxModel
(
"<h1>HACK</h1>"
);
}
}
}
@Issue
(
"SECURITY-1525"
)
public
void
testEnsureXSSnotPossible
()
throws
Exception
{
XssProperty
xssProperty
=
new
XssProperty
();
FreeStyleProject
p
=
createFreeStyleProject
();
p
.
addProperty
(
xssProperty
);
WebClient
wc
=
new
WebClient
();
HtmlPage
configurePage
=
wc
.
getPage
(
p
,
"configure"
);
int
numberOfH1Before
=
configurePage
.
getElementsByTagName
(
"h1"
).
size
();
HtmlElement
comboBox
=
configurePage
.
getElementByName
(
"_.xss"
);
HtmlElementUtil
.
click
(
comboBox
);
// no additional h1, meaning the "payload" is not interpreted
int
numberOfH1After
=
configurePage
.
getElementsByTagName
(
"h1"
).
size
();
assertEquals
(
numberOfH1Before
,
numberOfH1After
);
}
}
test/src/test/resources/lib/form/ComboBoxSEC1525Test/XssProperty/config.jelly
0 → 100644
浏览文件 @
00064be3
<?jelly escape-by-default='true'?>
<j:jelly xmlns:j="jelly:core" xmlns:f="/lib/form">
<f:entry field="xss">
<f:combobox />
</f:entry>
</j:jelly>
war/src/main/webapp/scripts/combobox.js
浏览文件 @
00064be3
...
...
@@ -246,7 +246,7 @@ ComboBox.prototype.populateDropdown = function() {
for
(
var
i
=
0
;
i
<
this
.
availableItems
.
length
;
i
++
)
{
var
item
=
document
.
createElement
(
"
div
"
);
item
.
className
=
"
comboBoxItem
"
;
item
.
inner
HTML
=
this
.
availableItems
[
i
];
item
.
inner
Text
=
this
.
availableItems
[
i
];
item
.
id
=
"
item_
"
+
this
.
availableItems
[
i
];
item
.
comboBox
=
this
;
item
.
comboBoxIndex
=
i
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录