1. 21 3月, 2019 2 次提交
  2. 20 3月, 2019 1 次提交
    • V
      Huge refactorig for consistent col/row numbering (#356) · dc012645
      Veniamin Albaev 提交于
      * Huge refactorig for consistent col/row numbering
      
      Started from simply changing ToALphaString()/TitleToNumber() logic and related fixes.
      But have to go deeper, do fixes, after do related fixes and again and again.
      
      Major improvements:
      
      1. Tests made stronger again (But still be weak).
      2. "Empty" returns for incorrect input replaces with panic.
      3. Check for correct col/row/cell naming & addressing by default.
      4. Removed huge amount of duplicated code.
      5. Removed ToALphaString(), TitleToNumber() and it helpers functions at all,
      and replaced with SplitCellName(), JoinCellName(), ColumnNameToNumber(), ColumnNumberToName(), CellNameToCoordinates(), CoordinatesToCellName().
      6. Minor fixes for internal variable naming for code readability (ex. col, row for input params, colIdx, rowIdx for slice indexes etc).
      
      * Formatting fixes
      dc012645
  3. 27 12月, 2018 1 次提交
    • V
      Tests refactoring · 35426ed5
      Veniamin Albaev 提交于
      Primary motivation: Avoid statefull tests with not ignorable git file tree changes.
      Multiple tests reads and overwrites signle file for won needs.
      Multiple tests reads and overwrites file under version control.
      
      Secondary motivation: Minimal tests logic aligment, separate error expectation
      and not error expectation tests. Introduce sub-test over test data sets and so far.
      
      This commit is not ideal but necessary (IMHO)
      35426ed5
  4. 31 1月, 2018 1 次提交
    • xurime's avatar
      - gofmted with -s; · 638bd44d
      xurime 提交于
      - Fix ineffectual assignments in Go code;
      - Godoc has been updated
      638bd44d
  5. 19 1月, 2018 1 次提交