Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xuri
excelize
提交
c72fb747
excelize
项目概览
xuri
/
excelize
通知
13
Star
2
Fork
4
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
excelize
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
未验证
提交
c72fb747
编写于
9月 10, 2022
作者:
D
dafengge0913
提交者:
GitHub
9月 10, 2022
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix DeleteComment slice bounds out of range (#1343)
上级
fb1aab7a
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
18 addition
and
11 deletion
+18
-11
comment.go
comment.go
+13
-10
comment_test.go
comment_test.go
+5
-1
未找到文件。
comment.go
浏览文件 @
c72fb747
...
...
@@ -156,17 +156,20 @@ func (f *File) DeleteComment(sheet, cell string) (err error) {
}
commentsXML
=
strings
.
TrimPrefix
(
commentsXML
,
"/"
)
if
comments
:=
f
.
commentsReader
(
commentsXML
);
comments
!=
nil
{
for
i
,
cmt
:=
range
comments
.
CommentList
.
Comment
{
if
cmt
.
Ref
==
cell
{
if
len
(
comments
.
CommentList
.
Comment
)
>
1
{
comments
.
CommentList
.
Comment
=
append
(
comments
.
CommentList
.
Comment
[
:
i
],
comments
.
CommentList
.
Comment
[
i
+
1
:
]
...
,
)
continue
}
comments
.
CommentList
.
Comment
=
nil
for
i
:=
0
;
i
<
len
(
comments
.
CommentList
.
Comment
);
i
++
{
cmt
:=
comments
.
CommentList
.
Comment
[
i
]
if
cmt
.
Ref
!=
cell
{
continue
}
if
len
(
comments
.
CommentList
.
Comment
)
>
1
{
comments
.
CommentList
.
Comment
=
append
(
comments
.
CommentList
.
Comment
[
:
i
],
comments
.
CommentList
.
Comment
[
i
+
1
:
]
...
,
)
i
--
continue
}
comments
.
CommentList
.
Comment
=
nil
}
f
.
Comments
[
commentsXML
]
=
comments
}
...
...
comment_test.go
浏览文件 @
c72fb747
...
...
@@ -55,15 +55,19 @@ func TestDeleteComment(t *testing.T) {
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"A40"
,
`{"author":"Excelize: ","text":"This is a comment1."}`
))
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"A41"
,
`{"author":"Excelize: ","text":"This is a comment2."}`
))
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"C41"
,
`{"author":"Excelize: ","text":"This is a comment3."}`
))
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"C41"
,
`{"author":"Excelize: ","text":"This is a comment3-1."}`
))
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"C42"
,
`{"author":"Excelize: ","text":"This is a comment4."}`
))
assert
.
NoError
(
t
,
f
.
AddComment
(
"Sheet2"
,
"C41"
,
`{"author":"Excelize: ","text":"This is a comment3-2."}`
))
assert
.
NoError
(
t
,
f
.
DeleteComment
(
"Sheet2"
,
"A40"
))
assert
.
EqualValues
(
t
,
2
,
len
(
f
.
GetComments
()[
"Sheet2"
]))
assert
.
EqualValues
(
t
,
5
,
len
(
f
.
GetComments
()[
"Sheet2"
]))
assert
.
EqualValues
(
t
,
len
(
NewFile
()
.
GetComments
()),
0
)
// Test delete all comments in a worksheet
assert
.
NoError
(
t
,
f
.
DeleteComment
(
"Sheet2"
,
"A41"
))
assert
.
NoError
(
t
,
f
.
DeleteComment
(
"Sheet2"
,
"C41"
))
assert
.
NoError
(
t
,
f
.
DeleteComment
(
"Sheet2"
,
"C42"
))
assert
.
EqualValues
(
t
,
0
,
len
(
f
.
GetComments
()[
"Sheet2"
]))
// Test delete comment on not exists worksheet
assert
.
EqualError
(
t
,
f
.
DeleteComment
(
"SheetN"
,
"A1"
),
"sheet SheetN does not exist"
)
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录