未验证 提交 4094e001 编写于 作者: xurime's avatar xurime 提交者: GitHub

Merge pull request #303 from CodeLingoBot/effective-go-fix-comments

Fix comments according to best practices by effective go
...@@ -337,7 +337,7 @@ func (f *File) RemoveCol(sheet, column string) { ...@@ -337,7 +337,7 @@ func (f *File) RemoveCol(sheet, column string) {
f.adjustHelper(sheet, col, -1, -1) f.adjustHelper(sheet, col, -1, -1)
} }
// Completion column element tags of XML in a sheet. // completeCol; Completion column element tags of XML in a sheet.
func completeCol(xlsx *xlsxWorksheet, row, cell int) { func completeCol(xlsx *xlsxWorksheet, row, cell int) {
buffer := bytes.Buffer{} buffer := bytes.Buffer{}
for r := range xlsx.SheetData.Row { for r := range xlsx.SheetData.Row {
......
...@@ -90,7 +90,7 @@ func julianDateToGregorianTime(part1, part2 float64) time.Time { ...@@ -90,7 +90,7 @@ func julianDateToGregorianTime(part1, part2 float64) time.Time {
return time.Date(year, time.Month(month), day, hours, minutes, seconds, nanoseconds, time.UTC) return time.Date(year, time.Month(month), day, hours, minutes, seconds, nanoseconds, time.UTC)
} }
// By this point generations of programmers have repeated the algorithm sent // doTheFliegelAndVanFlandernAlgorithm; By this point generations of programmers have repeated the algorithm sent
// to the editor of "Communications of the ACM" in 1968 (published in CACM, // to the editor of "Communications of the ACM" in 1968 (published in CACM,
// volume 11, number 10, October 1968, p.657). None of those programmers seems // volume 11, number 10, October 1968, p.657). None of those programmers seems
// to have found it necessary to explain the constants or variable names set // to have found it necessary to explain the constants or variable names set
......
...@@ -118,7 +118,7 @@ func trimCell(column []xlsxC) []xlsxC { ...@@ -118,7 +118,7 @@ func trimCell(column []xlsxC) []xlsxC {
return col[0:i] return col[0:i]
} }
// Read and update property of contents type of XLSX. // setContentTypes; Read and update property of contents type of XLSX.
func (f *File) setContentTypes(index int) { func (f *File) setContentTypes(index int) {
content := f.contentTypesReader() content := f.contentTypesReader()
content.Overrides = append(content.Overrides, xlsxOverride{ content.Overrides = append(content.Overrides, xlsxOverride{
...@@ -127,7 +127,7 @@ func (f *File) setContentTypes(index int) { ...@@ -127,7 +127,7 @@ func (f *File) setContentTypes(index int) {
}) })
} }
// Update sheet property by given index. // setSheet; Update sheet property by given index.
func (f *File) setSheet(index int, name string) { func (f *File) setSheet(index int, name string) {
var xlsx xlsxWorksheet var xlsx xlsxWorksheet
xlsx.Dimension.Ref = "A1" xlsx.Dimension.Ref = "A1"
...@@ -209,7 +209,7 @@ func (f *File) setAppXML() { ...@@ -209,7 +209,7 @@ func (f *File) setAppXML() {
f.saveFileList("docProps/app.xml", []byte(templateDocpropsApp)) f.saveFileList("docProps/app.xml", []byte(templateDocpropsApp))
} }
// Some tools that read XLSX files have very strict requirements about the // replaceRelationshipsNameSpaceBytes; Some tools that read XLSX files have very strict requirements about the
// structure of the input XML. In particular both Numbers on the Mac and SAS // structure of the input XML. In particular both Numbers on the Mac and SAS
// dislike inline XML namespace declarations, or namespace prefixes that don't // dislike inline XML namespace declarations, or namespace prefixes that don't
// match the ones that Excel itself uses. This is a problem because the Go XML // match the ones that Excel itself uses. This is a problem because the Go XML
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册