• V
    Huge refactorig for consistent col/row numbering (#356) · dc012645
    Veniamin Albaev 提交于
    * Huge refactorig for consistent col/row numbering
    
    Started from simply changing ToALphaString()/TitleToNumber() logic and related fixes.
    But have to go deeper, do fixes, after do related fixes and again and again.
    
    Major improvements:
    
    1. Tests made stronger again (But still be weak).
    2. "Empty" returns for incorrect input replaces with panic.
    3. Check for correct col/row/cell naming & addressing by default.
    4. Removed huge amount of duplicated code.
    5. Removed ToALphaString(), TitleToNumber() and it helpers functions at all,
    and replaced with SplitCellName(), JoinCellName(), ColumnNameToNumber(), ColumnNumberToName(), CellNameToCoordinates(), CoordinatesToCellName().
    6. Minor fixes for internal variable naming for code readability (ex. col, row for input params, colIdx, rowIdx for slice indexes etc).
    
    * Formatting fixes
    dc012645
picture.go 18.5 KB