1. 19 2月, 2012 1 次提交
    • D
      [SCSI] scsi_debug: GET LBA STATUS response length correction · de13e965
      Douglas Gilbert 提交于
      The SCSI GET LBA STATUS command was introduced in SBC-3 revision
      20 in September 2009. At that time the Parameter Data Length
      field in the response had an associated byte offset of 8.
      
      Then in SBC-3 revision 25 (October 2010) that byte offset was
      changed to 4. The sg_get_lba_status utility in sg3_utils version
      1.33 (released earlier today) has been changed to calculate
      the newer response length. However the implementation of
      GET LBA STATUS command in the scsi_debug driver still uses the
      original byte offset.
      
      modify the Parameter Data Length field value in the GET LBA STATUS command
      response to comply with the change in SBC-3 revision 25
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      de13e965
  2. 31 3月, 2011 1 次提交
  3. 15 3月, 2011 2 次提交
    • D
      [SCSI] scsi_debug: add consecutive medium errors · 32f7ef73
      Douglas Gilbert 提交于
      A useful test case for error recovery is multiple,
      consecutive medium errors. When scsi_debug is started
      with "opts=2" a MEDIUM ERROR is generated when block
      0x1234 (4660) is read. The patch extends that to
      10 consecutive blocks from 0x1234 (i.e. blocks 4660 to
      4669 inclusive).
      
      [0:0:0:0]  disk  ATA    INTEL SSD  2CV1 /dev/sda /dev/sg0 80.0GB
      [10:0:0:0] disk  Linux  scsi_debug 0004 /dev/sdb /dev/sg1 1.09TB
      
      Output file not specified so no copy, just reading input
       >> unrecovered read error at blk=4660, substitute zeros
      ...
       >> unrecovered read error at blk=4669, substitute zeros
      4670+10 records in
      0+0 records out
      10 unrecovered read errors
      lowest unrecovered read lba=4660, highest unrecovered lba=4669
      time to read data: 0.047943 secs at 49.87 MB/sec
      
      BTW Change /dev/sg1 (bsg device works just as well) to
      /dev/sdb to see why, with faulty media, you do not want
      to use the block layer interface. Reason: time block
      layer takes to do useless retries and collateral damage
      to data in its 4 KB blocks (O_DIRECT mitigates the
      latter).
      
      ChangeLog:
          - extend opts=2 medium error generation at block
            0x1234 to 10 consecutive blocks (i.e. blocks
            0x1234 to 0x123d).
      Signed-off-by: NDouglas Gilbert <dgilbert@interlog.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      32f7ef73
    • M
      [SCSI] scsi_debug: Logical Block Provisioning (SBC3r26) · 5b94e232
      Martin K. Petersen 提交于
      Update scsi_debug to support the Logical Block Provisioning commands and
      bits as defined in SBC3r26. The old tp* parameters have been
      transitioned to the new lbp* scheme found in the draft standard.
      
      The old tpu option to enable UNMAP is now called lbpu. tpws to signal
      support for WRITE SAME(16) with the UNMAP bit set is now lbpws. Support
      for WRITE SAME(10) with the UNMAP bit set is also available using the
      lpuws10 parameter.
      
      Limiting the maximum number of blocks per WRITE SAME command has been
      implemented and is available via the write_same_length module parameter.
      
      As part of the renaming process the parameter lists have been sorted
      alphabetically (request from Doug).
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      Acked-by: NDouglas Gilbert <dgilbert@interlog.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      5b94e232
  4. 13 2月, 2011 1 次提交
  5. 23 12月, 2010 1 次提交
  6. 17 11月, 2010 1 次提交
    • J
      SCSI host lock push-down · f281233d
      Jeff Garzik 提交于
      Move the mid-layer's ->queuecommand() invocation from being locked
      with the host lock to being unlocked to facilitate speeding up the
      critical path for drivers who don't need this lock taken anyway.
      
      The patch below presents a simple SCSI host lock push-down as an
      equivalent transformation.  No locking or other behavior should change
      with this patch.  All existing bugs and locking orders are preserved.
      
      Additionally, add one parameter to queuecommand,
      	struct Scsi_Host *
      and remove one parameter from queuecommand,
      	void (*done)(struct scsi_cmnd *)
      
      Scsi_Host* is a convenient pointer that most host drivers need anyway,
      and 'done' is redundant to struct scsi_cmnd->scsi_done.
      
      Minimal code disturbance was attempted with this change.  Most drivers
      needed only two one-line modifications for their host lock push-down.
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      Acked-by: NJames Bottomley <James.Bottomley@suse.de>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      f281233d
  7. 17 9月, 2010 1 次提交
  8. 10 9月, 2010 1 次提交
  9. 28 7月, 2010 1 次提交
  10. 02 5月, 2010 1 次提交
  11. 01 5月, 2010 1 次提交
  12. 12 4月, 2010 1 次提交
    • D
      [SCSI] scsi_debug: add max_queue + no_uld parameters · 78d4e5a0
      Douglas Gilbert 提交于
      While testing the midlevel q_at_head and q_at_tail
      patch for sg and the block SG_IO ioctl I found it
      useful to reduce the queuing within the scsi_debug
      driver. The reason is that the midlevel queue only
      comes into play when the corresponding LLD queue
      is full.
      
      It is also useful when testing to be confident that
      your program is the only thing issuing commands
      to the (virtual) scsi_debug device. The no_uld=1
      parameter will stop a scsi_debug virtual disk
      appearing as /dev/sd* .
      
      Changelog:
         - add max_queue parameter to reduce the number
           of queued commands the driver will accept.
           This parameter can be changed after the driver
           is loaded.
         - add no_uld parameter that restricts scsi_debug's
           virtual devices to the sg and bsg drivers
         - correct stale url
      Signed-off-by: NDouglas Gilbert <dgilbert@interlog.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      78d4e5a0
  13. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  14. 05 12月, 2009 2 次提交
    • D
      [SCSI] scsi_debug: fix Thin provisioning support · 1e49f785
      Douglas Gilbert 提交于
      While testing scsi_debug with these patches I found a
      problem with the Block Limits VPD page function. The
      length returned by the inquiry_evpd_b0() function was
      too short. A patch to fix that and a cosmetic change
      (that the form factor of scsi_debug is less than 1.8
      inches) is attached.
      Signed-off-by: NDouglas Gilbert <dgilbert@interlog.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      1e49f785
    • M
      [SCSI] scsi_debug: Thin provisioning support · 44d92694
      Martin K. Petersen 提交于
      This version fixes 64-bit modulo on 32-bit as well as inadvertent map
      updates when TP was disabled.
      
      Implement support for thin provisioning in scsi_debug.  No actual memory
      de-allocation is taking place.  The intent is to emulate a thinly
      provisioned storage device, not to be one.
      
      There are four new module options:
      
       - unmap_granularity specifies the granularity at which to track mapped
         blocks (specified in number of logical blocks).  2048 (1 MB) is a
         realistic value for disk arrays although some may have a finer
         granularity.
      
       - unmap_alignment specifies the first LBA which is naturally aligned on
         an unmap_granularity boundary.
      
       - unmap_max_desc specifies the maximum number of ranges that can be
         unmapped using one UNMAP command.  If this is 0, only WRITE SAME is
         supported and UNMAP will cause a check condition.
      
       - unmap_max_blocks specifies the maximum number of blocks that can be
         unmapped using a single UNMAP command.  Default is 0xffffffff.
      
      These parameters are reported in the new and extended block limits VPD.
      
      If unmap_granularity is specified the device is tagged as thin
      provisioning capable in READ CAPACITY(16).  A bitmap is allocated to
      track whether blocks are mapped or not.  A WRITE request will cause a
      block to be mapped.  So will WRITE SAME unless the UNMAP bit is set.
      
      Blocks can be unmapped using either WRITE SAME or UNMAP.  No accounting
      is done to track partial blocks.  This means that only whole blocks will
      be marked free.  This is how the array people tell me their firmwares
      work.
      
      GET LBA STATUS is also supported.  This command reports whether a block
      is mapped or not, and how long the adjoining mapped/unmapped extent is.
      
      The block allocation bitmap can also be viewed from user space via:
      
      	/sys/bus/pseudo/drivers/scsi_debug/map
      Signed-off-by: NMartin K. Petersen <martin.petersen@oracle.com>
      Acked-by: NDouglas Gilbert <dgilbert@interlog.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      44d92694
  15. 02 10月, 2009 1 次提交
  16. 22 6月, 2009 1 次提交
  17. 21 5月, 2009 1 次提交
  18. 13 3月, 2009 1 次提交
  19. 03 1月, 2009 1 次提交
  20. 27 7月, 2008 1 次提交
  21. 12 7月, 2008 2 次提交
  22. 29 4月, 2008 1 次提交
  23. 08 4月, 2008 15 次提交