1. 21 4月, 2009 1 次提交
  2. 07 3月, 2009 1 次提交
    • H
      xfs: include header files for prototypes · 7bf446f8
      Hannes Eder 提交于
      Fix this sparse warnings:
        fs/xfs/linux-2.6/xfs_ioctl.c:72:1: warning: symbol 'xfs_find_handle' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:249:1: warning: symbol 'xfs_open_by_handle' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:361:1: warning: symbol 'xfs_readlink_by_handle' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:496:1: warning: symbol 'xfs_attrmulti_attr_get' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:525:1: warning: symbol 'xfs_attrmulti_attr_set' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:555:1: warning: symbol 'xfs_attrmulti_attr_remove' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:657:1: warning: symbol 'xfs_ioc_space' was not declared. Should it be static?
        fs/xfs/linux-2.6/xfs_ioctl.c:1340:1: warning: symbol 'xfs_file_ioctl' was not declared. Should it be static?
        fs/xfs/support/debug.c:65:1: warning: symbol 'xfs_fs_vcmn_err' was not declared. Should it be static?
        fs/xfs/support/debug.c:112:1: warning: symbol 'xfs_hex_dump' was not declared. Should it be static?
      Signed-off-by: NHannes Eder <hannes@hanneseder.net>
      Reviewed-by: NChristoph Hellwig <hch@lst.de>
      Signed-off-by: NFelix Blyakher <felixb@sgi.com>
      7bf446f8
  3. 09 2月, 2009 1 次提交
  4. 19 1月, 2009 2 次提交
    • C
      xfs: fix dentry aliasing issues in open_by_handle · ab596ad8
      Christoph Hellwig 提交于
      Open by handle just grabs an inode by handle and then creates itself
      a dentry for it.  While this works for regular files it is horribly
      broken for directories, where the VFS locking relies on the fact that
      there is only just one single dentry for a given inode, and that
      these are always connected to the root of the filesystem so that
      it's locking algorithms work (see Documentations/filesystems/Locking)
      
      Remove all the existing open by handle code and replace it with a small
      wrapper around the exportfs code which deals with all these issues.
      At the same time we also make the checks for a valid handle strict
      enough to reject all not perfectly well formed handles - given that
      we never hand out others that's okay and simplifies the code.
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      Reviewed-by: NDave Chinner <david@fromorbit.com>
      ab596ad8
    • C
      xfs: fix dentry aliasing issues in open_by_handle · d296d30a
      Christoph Hellwig 提交于
      Open by handle just grabs an inode by handle and then creates itself
      a dentry for it.  While this works for regular files it is horribly
      broken for directories, where the VFS locking relies on the fact that
      there is only just one single dentry for a given inode, and that
      these are always connected to the root of the filesystem so that
      it's locking algorithms work (see Documentations/filesystems/Locking)
      
      Remove all the existing open by handle code and replace it with a small
      wrapper around the exportfs code which deals with all these issues.
      At the same time we also make the checks for a valid handle strict
      enough to reject all not perfectly well formed handles - given that
      we never hand out others that's okay and simplifies the code.
      Signed-off-by: NChristoph Hellwig <hch@lst.de>
      Reviewed-by: NDave Chinner <david@fromorbit.com>
      d296d30a
  5. 10 1月, 2009 1 次提交
  6. 11 12月, 2008 1 次提交
  7. 02 12月, 2008 3 次提交
  8. 01 12月, 2008 2 次提交
  9. 14 11月, 2008 2 次提交
  10. 31 10月, 2008 1 次提交
  11. 30 10月, 2008 2 次提交
  12. 23 10月, 2008 1 次提交
  13. 13 8月, 2008 1 次提交
  14. 28 7月, 2008 5 次提交
  15. 27 7月, 2008 1 次提交
    • A
      [PATCH] sanitize __user_walk_fd() et.al. · 2d8f3038
      Al Viro 提交于
      * do not pass nameidata; struct path is all the callers want.
      * switch to new helpers:
      	user_path_at(dfd, pathname, flags, &path)
      	user_path(pathname, &path)
      	user_lpath(pathname, &path)
      	user_path_dir(pathname, &path)  (fail if not a directory)
        The last 3 are trivial macro wrappers for the first one.
      * remove nameidata in callers.
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      2d8f3038
  16. 29 4月, 2008 2 次提交
  17. 19 4月, 2008 1 次提交
  18. 18 4月, 2008 3 次提交
  19. 10 4月, 2008 1 次提交
  20. 15 2月, 2008 2 次提交
  21. 07 2月, 2008 5 次提交
  22. 10 12月, 2007 1 次提交
    • L
      [XFS] 971064 Various fixups for xfs_bulkstat(). · cd57e594
      Lachlan McIlroy 提交于
      - sanity check for NULL user buffer in xfs_ioc_bulkstat[_compat]()
      - remove the special case for XFS_IOC_FSBULKSTAT with count == 1. This
        special case causes bulkstat to fail because the special case uses
        xfs_bulkstat_single() instead of xfs_bulkstat() and the two functions
        have different semantics.  xfs_bulkstat() will return the next inode
        after the one supplied while skipping internal inodes (ie quota inodes).
        xfs_bulkstate_single() will only lookup the inode supplied and return
        an error if it is an internal inode.
      - in xfs_bulkstat(), need to initialise 'lastino' to the inode supplied
        so in cases were we return without examining any inodes the scan wont
        restart back at zero.
      - sanity check for valid *ubcountp values. Cannot sanity check for valid
        ubuffer here because some users of xfs_bulkstat() don't supply a buffer.
      - checks against 'ubleft' (the space left in the user's buffer) should be
        against 'statstruct_size' which is the supplied minimum object size.
        The mixture of checks against statstruct_size and 0 was one of the
        reasons we were skipping inodes.
      - if the formatter function returns BULKSTAT_RV_NOTHING and an error and
        the error is not ENOENT or EINVAL then we need to abort the scan. ENOENT
        is for inodes that are no longer valid and we just skip them. EINVAL is
        returned if we try to lookup an internal inode so we skip them too. For
        a DMF scan if the inode and DMF attribute cannot fit into the space left
        in the user's buffer it would return ERANGE. We didn't handle this error
        and skipped the inode. We would continue to skip inodes until one fitted
        into the user's buffer or we completed the scan.
      - put back the recalculation of agino (that got removed with the last fix)
        at the end of the while loop. This is because the code at the start of
        the loop expects agino to be the last inode examined if it is non-zero.
      - if we found some inodes but then encountered an error, return success
        this time and the error next time. If the formatter aborted with ENOMEM
        we will now return this error but only if we couldn't read any inodes.
        Previously if we encountered ENOMEM without reading any inodes we
        returned a zero count and no error which falsely indicated the scan was
        complete.
      
      SGI-PV: 973431
      SGI-Modid: xfs-linux-melb:xfs-kern:30089a
      Signed-off-by: NLachlan McIlroy <lachlan@sgi.com>
      Signed-off-by: NDavid Chinner <dgc@sgi.com>
      cd57e594