1. 21 2月, 2008 2 次提交
    • H
      nfs: fix sparse warnings · 90dc7d27
      Harvey Harrison 提交于
      fs/nfs/nfs4state.c:788:34: warning: Using plain integer as NULL pointer
      fs/nfs/delegation.c:52:34: warning: Using plain integer as NULL pointer
      fs/nfs/idmap.c:312:12: warning: Using plain integer as NULL pointer
      fs/nfs/callback_xdr.c:257:6: warning: Using plain integer as NULL pointer
      fs/nfs/callback_xdr.c:270:6: warning: Using plain integer as NULL pointer
      fs/nfs/callback_xdr.c:281:6: warning: Using plain integer as NULL pointer
      Signed-off-by: NHarvey Harrison <harvey.harrison@gmail.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      90dc7d27
    • J
      NFS: flush signals before taking down callback thread · 1227a74e
      Jeff Layton 提交于
      Now that the reference counting on the callback thread is working as
      expected, it uncovers another problem.  Peter Staubach noticed while
      testing that patch on an older kernel that he would occasionally see
      this printk in rpc_register fire:
      
          "RPC: failed to contact portmap (errno -512).
      
      The NFSv4 callback thread is signaled by nfs_callback_down(), but never
      flushes that signal. All of the shutdown processing is done with that
      signal pending. This makes it fail the call to unregister the port with
      the portmapper.
      
      In actuality, this rpc_register call isn't necessary at all since the
      port isn't actually registered with the portmapper anymore. Regardless,
      there doesn't seem to be any reason to leave the signal pending while
      the thread is being shut down and flushing it should generally silence
      that printk.
      Signed-off-by: NJeff Layton <jlayton@redhat.com>
      Signed-off-by: NTrond Myklebust <Trond.Myklebust@netapp.com>
      1227a74e
  2. 20 2月, 2008 38 次提交