提交 b0884e25 编写于 作者: M Markus Metzger 提交者: Ingo Molnar

x86, bts: turn BUG_ON into WARN_ON_ONCE

Impact: make the ds code more debuggable

Turn BUG_ON's into WARN_ON_ONCE.
Signed-off-by: NMarkus Metzger <markus.t.metzger@intel.com>
Signed-off-by: NIngo Molnar <mingo@elte.hu>
上级 f3134de6
...@@ -452,7 +452,7 @@ struct pebs_tracer *ds_request_pebs(struct task_struct *task, ...@@ -452,7 +452,7 @@ struct pebs_tracer *ds_request_pebs(struct task_struct *task,
static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual) static void ds_release(struct ds_tracer *tracer, enum ds_qualifier qual)
{ {
BUG_ON(tracer->context->owner[qual] != tracer); WARN_ON_ONCE(tracer->context->owner[qual] != tracer);
tracer->context->owner[qual] = NULL; tracer->context->owner[qual] = NULL;
put_tracer(tracer->context->task); put_tracer(tracer->context->task);
...@@ -774,7 +774,7 @@ ds_configure(const struct ds_configuration *cfg) ...@@ -774,7 +774,7 @@ ds_configure(const struct ds_configuration *cfg)
printk(KERN_INFO "DS available\n"); printk(KERN_INFO "DS available\n");
BUG_ON(MAX_SIZEOF_DS < ds_cfg.sizeof_ds); WARN_ON_ONCE(MAX_SIZEOF_DS < ds_cfg.sizeof_ds);
} }
void __cpuinit ds_init_intel(struct cpuinfo_x86 *c) void __cpuinit ds_init_intel(struct cpuinfo_x86 *c)
......
...@@ -878,7 +878,8 @@ static int ptrace_bts_write_record(struct task_struct *child, ...@@ -878,7 +878,8 @@ static int ptrace_bts_write_record(struct task_struct *child,
{ {
unsigned char bts_record[BTS_MAX_RECORD_SIZE]; unsigned char bts_record[BTS_MAX_RECORD_SIZE];
BUG_ON(BTS_MAX_RECORD_SIZE < bts_cfg.sizeof_bts); if (BTS_MAX_RECORD_SIZE < bts_cfg.sizeof_bts)
return -EOVERFLOW;
memset(bts_record, 0, bts_cfg.sizeof_bts); memset(bts_record, 0, bts_cfg.sizeof_bts);
switch (in->qualifier) { switch (in->qualifier) {
...@@ -1133,7 +1134,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data) ...@@ -1133,7 +1134,7 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
ret = ds_get_bts_index(child->bts, &size); ret = ds_get_bts_index(child->bts, &size);
if (ret == 0) { if (ret == 0) {
BUG_ON(size != (int) size); WARN_ON_ONCE(size != (int) size);
ret = (int) size; ret = (int) size;
} }
break; break;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册