提交 60b7d14a 编写于 作者: N Namhyung Kim 提交者: Arnaldo Carvalho de Melo

perf sched: Fixup for the die() removal

The commit a116e05d ("perf sched: Remove die() calls") replaced
die() call to pr_debug + return -1, but it should be pr_err otherwise
it'll not show up unless -v option is given.  Fix it.
Signed-off-by: NNamhyung Kim <namhyung@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Link: http://lkml.kernel.org/r/1347415866-303-2-git-send-email-namhyung@kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
上级 bb77ac3a
...@@ -438,8 +438,8 @@ static int self_open_counters(void) ...@@ -438,8 +438,8 @@ static int self_open_counters(void)
fd = sys_perf_event_open(&attr, 0, -1, -1, 0); fd = sys_perf_event_open(&attr, 0, -1, -1, 0);
if (fd < 0) if (fd < 0)
pr_debug("Error: sys_perf_event_open() syscall returned" pr_err("Error: sys_perf_event_open() syscall returned "
"with %d (%s)\n", fd, strerror(errno)); "with %d (%s)\n", fd, strerror(errno));
return fd; return fd;
} }
...@@ -700,7 +700,7 @@ static int replay_switch_event(struct perf_sched *sched, ...@@ -700,7 +700,7 @@ static int replay_switch_event(struct perf_sched *sched,
delta = 0; delta = 0;
if (delta < 0) { if (delta < 0) {
pr_debug("hm, delta: %" PRIu64 " < 0 ?\n", delta); pr_err("hm, delta: %" PRIu64 " < 0 ?\n", delta);
return -1; return -1;
} }
...@@ -990,7 +990,7 @@ static int latency_runtime_event(struct perf_sched *sched, ...@@ -990,7 +990,7 @@ static int latency_runtime_event(struct perf_sched *sched,
return -1; return -1;
atoms = thread_atoms_search(&sched->atom_root, thread, &sched->cmp_pid); atoms = thread_atoms_search(&sched->atom_root, thread, &sched->cmp_pid);
if (!atoms) { if (!atoms) {
pr_debug("in-event: Internal tree error"); pr_err("in-event: Internal tree error");
return -1; return -1;
} }
if (add_sched_out_event(atoms, 'R', timestamp)) if (add_sched_out_event(atoms, 'R', timestamp))
...@@ -1024,7 +1024,7 @@ static int latency_wakeup_event(struct perf_sched *sched, ...@@ -1024,7 +1024,7 @@ static int latency_wakeup_event(struct perf_sched *sched,
return -1; return -1;
atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid); atoms = thread_atoms_search(&sched->atom_root, wakee, &sched->cmp_pid);
if (!atoms) { if (!atoms) {
pr_debug("wakeup-event: Internal tree error"); pr_err("wakeup-event: Internal tree error");
return -1; return -1;
} }
if (add_sched_out_event(atoms, 'S', timestamp)) if (add_sched_out_event(atoms, 'S', timestamp))
...@@ -1079,7 +1079,7 @@ static int latency_migrate_task_event(struct perf_sched *sched, ...@@ -1079,7 +1079,7 @@ static int latency_migrate_task_event(struct perf_sched *sched,
register_pid(sched, migrant->pid, migrant->comm); register_pid(sched, migrant->pid, migrant->comm);
atoms = thread_atoms_search(&sched->atom_root, migrant, &sched->cmp_pid); atoms = thread_atoms_search(&sched->atom_root, migrant, &sched->cmp_pid);
if (!atoms) { if (!atoms) {
pr_debug("migration-event: Internal tree error"); pr_err("migration-event: Internal tree error");
return -1; return -1;
} }
if (add_sched_out_event(atoms, 'R', timestamp)) if (add_sched_out_event(atoms, 'R', timestamp))
...@@ -1286,7 +1286,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel, ...@@ -1286,7 +1286,7 @@ static int map_switch_event(struct perf_sched *sched, struct perf_evsel *evsel,
delta = 0; delta = 0;
if (delta < 0) { if (delta < 0) {
pr_debug("hm, delta: %" PRIu64 " < 0 ?\n", delta); pr_err("hm, delta: %" PRIu64 " < 0 ?\n", delta);
return -1; return -1;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册